Refactor many things

Author: Not-A-Normal-Robot

.github/workflows/deno.yml

@@ -27,4 +27,4 @@ jobs:
           deno-version: v1.x
 
       - name: Run linter
-        run: deno lint --ignore=node_modules,./.*,*.min.*
+        run: deno lint --ignore=node_modules,./.*,**/*.min.js

assets/data/faq.ts

@@ -1,4 +1,4 @@
-import { type FAQEntry, Tag } from "../types/faq";
+import { Tag } from "../types/faq";
 
 export default {
     'what-is-techmino': {

assets/scripts/background.ts

@@ -101,11 +101,11 @@ function onResize() {
     bgCanvas.width = width;
     bgCanvas.height = height;
 
-    let starCount = Math.floor(width * height * 6e-4);
+    const starCount = Math.floor(width * height * 6e-4);
     stars = new Array(starCount);
 
     for (let i = 0; i < starCount; i++) {
-        let size = random(2.6, 4);
+        const size = random(2.6, 4);
         stars[i] = {
             size: size,
             x: random(-10, width + 10),

assets/scripts/database.ts

@@ -2,7 +2,6 @@ import { ref } from 'vue';
 import {
     createClient,
     SupabaseClient,
-    type PostgrestError,
     type SupabaseClientOptions,
     type User
 } from '@supabase/supabase-js';

assets/scripts/replay/analyzer.ts

@@ -40,7 +40,7 @@ export type KeyDurationStats = {
 };
 
 function getEmptyKeyDurationStats(): KeyDurationStats {
-    let partial: Partial<KeyDurationStats> = {};
+    const partial: Partial<KeyDurationStats> = {};
 
     for(const key of Object.values(InputKey)) {
         partial[key] = {
@@ -69,10 +69,10 @@ function getEmptyKeyDurationStats(): KeyDurationStats {
 export function getReplayKeyDurationStats(
     replayData: GameReplayData
 ): KeyDurationStats {
-    let keyDurationStats = getEmptyKeyDurationStats();
+    const keyDurationStats = getEmptyKeyDurationStats();
 
-    let timeOfPreviousPress: Record<InputKey, number> = (function() {
-        let partial: Partial<Record<InputKey, number>> = {};
+    const timeOfPreviousPress: Record<InputKey, number> = (function() {
+        const partial: Partial<Record<InputKey, number>> = {};
 
         for(const key of Object.values(InputKey)) {
             partial[key] = Infinity;
@@ -99,7 +99,7 @@ export function getReplayKeyDurationStats(
     }
 
     // Process inputs for additional statistics
-    for(let key of Object.values(InputKey)) {
+    for(const key of Object.values(InputKey)) {
         // Calculate the 25th, 50th (median), and 75th percentiles
         {
             const durations = Object.keys(keyDurationStats[key].durations).map(Number);
@@ -116,7 +116,7 @@ export function getReplayKeyDurationStats(
 
             let percentile25Set = false;
             let medianSet = false;
-            let percentile75Set = false
+            let percentile75Set = false;
 
             for(const duration of durations) {
                 const durationInstances = keyDurationStats[key].durations[duration] ?? 0;
@@ -385,7 +385,7 @@ export function getReplayLocalKps(replayData: GameReplayData, filter?: InputKey,
  * @param replayData The replay data to analyze.
  */
 export function getUsedKeys(replayData: GameReplayData) {
-    let usedKeys = new Set<InputKey>();
+    const usedKeys = new Set<InputKey>();
 
     for(const input of replayData.inputs) {
         if(input.type === InputEventType.Press) {
@@ -402,7 +402,7 @@ export function getUsedKeys(replayData: GameReplayData) {
  * @param gameMode The game mode to get the KPS limit for.
  * @returns The KPS limit for the given game mode.
  */
-function getKpsLimit(gameMode: string) {
+export function getKpsLimit(gameMode: string) {
     const kpsLimits = {
         sprint123: 60,
         classic: 30,

assets/types/database.ts

@@ -1,5 +1,3 @@
-import { createClient, SupabaseClient, type SupabaseClientOptions } from "@supabase/supabase-js";
-
 /**
  * The Profile type represents a user's profile.  
  * This should be what you get from querying from the `public.profiles` table.
@@ -60,7 +58,7 @@ export type Submission = {
      * It is different for each game mode, and can even be null.  
      * Postgres type: jsonb
      */
-    score: Record<string | number, any> | null;
+    score: Record<string | number, unknown> | null;
 
     /**
      * The timestamp when the submission was uploaded.  

assets/types/lang.ts

@@ -1,6 +1,7 @@
 /** Language entry type. */
 export type LangEntry = {
-    [key: string]: string | string[] | ((...args: any) => string) | LangEntry
+    [key: string]:
+        string | string[] | ((...args: unknown[]) => string) | LangEntry
 };
 
 /** The prefix of a string if it should be processed in Markdown */

assets/types/map.ts

@@ -8,6 +8,33 @@ export type MapData = {
     starting_mode: string
 }
 
+function isRecord(candidate: unknown): candidate is Record<string, unknown> {
+    return !!(typeof candidate === 'object' && candidate);
+}
+
+const mapDataSchema = {
+    modes: 'object',
+    min_x: 'number',
+    max_x: 'number',
+    min_y: 'number',
+    max_y: 'number',
+    starting_mode: 'string'
+} as const;
+
+function recordFollowsMapDataSchema(rec: Record<string, unknown>): rec is MapData {
+    for(const key of Object.keys(mapDataSchema) as (keyof typeof mapDataSchema)[]) {
+        if(!(key in rec) || (typeof rec[key]) !== mapDataSchema[key]) {
+            return false;
+        }
+
+        if(mapDataSchema[key] === 'object' && !isRecord(rec[key])) {
+            return false;
+        }
+    }
+
+    return true;
+}
+
 /**
  * Checks if the given map data is valid.
  * 
@@ -20,23 +47,9 @@ export type MapData = {
  * 
  * @returns Whether or not the map data is valid
  */
-export function isMapDataValid(mapData: any, strict: boolean = false): mapData is MapData {
-    if(!mapData || typeof mapData !== 'object') { return false; }
-    
-    const schema = {
-        modes: 'object',
-        min_x: 'number',
-        max_x: 'number',
-        min_y: 'number',
-        max_y: 'number',
-        starting_mode: 'string'
-    } as const;
-
-    for(const key of Object.keys(schema) as (keyof typeof schema)[]) {
-        if(!(key in mapData) || (typeof mapData[key]) !== schema[key]) {
-            return false;
-        }
-    }
+export function isMapDataValid(mapData: unknown, strict: boolean = false): mapData is MapData {
+    if(!isRecord(mapData)) return false;
+    if(!recordFollowsMapDataSchema(mapData)) return false;
 
     if(!mapData.modes[mapData.starting_mode]) {
         return false;
@@ -77,8 +90,9 @@ export type Mode = {
  * @param mode The candidate mode to be validated.
  * @returns Whether or not the mode is valid.
  */
-export function isModeValid(mode: any): mode is Mode {
-    if(!mode || typeof mode !== 'object') { return false; }
+// @ts-ignore | "`any` type is not allowed"
+export function isModeValid(mode: unknown): mode is Mode {
+    if(!isRecord(mode)) { return false; }
 
     const schema = {
         name: 'string',
@@ -121,19 +135,19 @@ export type Rank = typeof Rank[keyof typeof Rank];
 
 
 export const modeShapeNames = (() => {
-    let names = new Map<ModeShape, string>();
+    const names = new Map<ModeShape, string>();
 
-    for(let [key, value] of Object.entries(ModeShape)) {
+    for(const [key, value] of Object.entries(ModeShape)) {
         names.set(value, key);
     }
 
     return names as Map<ModeShape, keyof typeof ModeShape>;
 })();
 
 export const rankNames = (() => {
-    let names = new Map<Rank, string>();
+    const names = new Map<Rank, string>();
 
-    for(let [key, value] of Object.entries(Rank)) {
+    for(const [key, value] of Object.entries(Rank)) {
         names.set(value, key);
     }
 

deno.json

@@ -0,0 +1,8 @@
+{
+    "lint": {
+        "rules": {
+            "tags": ["recommended"],
+            "exclude": ["no-node-globals"]
+        }
+    }
+}

i18n.config.ts

@@ -38,7 +38,7 @@ function processLangEntry(entries: LangEntry): LangEntry {
     const newEntries: LangEntry = {};
 
     for(const key in entries) {
-        let entry = entries[key];
+        const entry = entries[key];
 
         if(typeof entry === 'string') {
             newEntries[key] = renderString(entry);

package.json

@@ -8,7 +8,8 @@
     "generate": "nuxt generate",
     "preview": "nuxt preview",
     "postinstall": "nuxt prepare",
-    "lint": "deno lint --ignore=node_modules,./.*,*.min.*"
+    "lint": "deno lint --ignore=node_modules,./.*,**/*.min.js",
+    "lintless": "npm run lint > lint_output.log 2>&1 || less -R lint_output.log"
   },
   "dependencies": {
     "@nuxt/kit": "^3.13.1",

plugins/thtml-directive.ts

@@ -1,3 +1,5 @@
+import { type DirectiveBinding } from "vue";
+
 // Workaround for v-html not being supported for custom elements
 // Source: https://github.com/nuxt/nuxt/issues/10333#issuecomment-1842692933
 
@@ -6,10 +8,10 @@
 // If v-html works, use that instead.
 export default defineNuxtPlugin((nuxtApp) => {
     nuxtApp.vueApp.directive('thtml', {
-        mounted: (el: HTMLElement, binding: any) => {
+        mounted: (el: HTMLElement, binding: DirectiveBinding) => {
             el.innerHTML = binding.value;
         },
-        getSSRProps(binding: any) {
+        getSSRProps(binding: DirectiveBinding) {
             return {
                 innerHTML: binding.value
             };

plugins/tl-with-fallback.ts

@@ -1,5 +1,3 @@
-import { type TranslateOptions } from 'vue-i18n';
-
 /**
  * Translate with a key if it exists, otherwise fallback to another key.
  * 
@@ -30,7 +28,7 @@ export function translateWithFallback(
     }
 }
 
-export default defineNuxtPlugin((nuxtApp) => {
+export default defineNuxtPlugin(() => {
     const tf = translateWithFallback;
 
     return {

server/api/v1/check-avatar.ts

@@ -14,7 +14,7 @@ import { useDatabase } from "~/composables/database";
 export default defineEventHandler(async (event) => {
     const query = getQuery(event);
 
-    let id = query.id;
+    const id = query.id;
 
     if (!id) {
         throw createError({
@@ -47,7 +47,7 @@ export default defineEventHandler(async (event) => {
         });
 
         return response.ok;
-    } catch {}
-
-    return false;
+    } catch {
+        return false;
+    }
 });

server/api/v1/fetch-article.ts

@@ -100,7 +100,7 @@ export default defineEventHandler(async (event) => {
     let text = "";
 
     try {
-        let res = await fetch(path);
+        const res = await fetch(path);
 
         if(!res.ok) {
             throw createError({

server/api/v1/fetch-leaderboard.ts

@@ -1,7 +1,6 @@
 import { RECORD_SCHEMAS } from '~/assets/data/record-schemas';
-import { Submission, SubmissionValidity } from '~/assets/types/database';
+import { SubmissionValidity } from '~/assets/types/database';
 import { useDatabase } from '~/composables/database';
-import { type PostgrestError } from '@supabase/supabase-js';
 
 /**
  * @api {get} /api/v1/fetch-leaderboard Fetch leaderboard
@@ -26,7 +25,7 @@ import { type PostgrestError } from '@supabase/supabase-js';
 export default defineEventHandler(async (event) => {
     const query = getQuery(event);
 
-    let gameMode = query.gameMode;
+    const gameMode = query.gameMode;
 
     if(!gameMode) {
         throw createError({
@@ -143,7 +142,7 @@ export default defineEventHandler(async (event) => {
     let reverse = false;
 
     if(query.reverse) {
-        let reverseQuery = query.reverse;
+        const reverseQuery = query.reverse;
 
         if(typeof reverseQuery === 'boolean') {
             reverse = reverseQuery;

server/api/v1/fetch-profile-submissions.ts

@@ -21,7 +21,7 @@ import { useDatabase } from '~/composables/database';
 export default defineEventHandler(async (event) => {
     const query = getQuery(event);
 
-    let id = query.id;
+    const id = query.id;
 
     if (!id) {
         throw createError({
@@ -58,7 +58,7 @@ export default defineEventHandler(async (event) => {
             }
 
             if(typeof limitQuery === 'string') {
-                let casted = parseInt(limitQuery);
+                const casted = parseInt(limitQuery);
 
                 if(!isFinite(casted)) {
                     throw createError({
@@ -95,7 +95,7 @@ export default defineEventHandler(async (event) => {
             }
 
             if(typeof offsetQuery === 'string') {
-                let casted = parseInt(offsetQuery);
+                const casted = parseInt(offsetQuery);
 
                 if(!isFinite(casted)) {
                     throw createError({

server/api/v1/fetch-profile.ts

@@ -18,8 +18,8 @@ import { useDatabase } from '~/composables/database';
 export default defineEventHandler(async (event) => {
     const query = getQuery(event);
 
-    let uuid = query.uuid;
-    let username = query.username;
+    const uuid = query.uuid;
+    const username = query.username;
 
     if(!uuid && !username) {
         throw createError({
@@ -74,7 +74,7 @@ export default defineEventHandler(async (event) => {
             });
         }
 
-        let error = err as PostgrestError | Error;
+        const error = err as PostgrestError | Error;
 
         if(error.message.toLowerCase().includes("not found")) {
             throw createError({