feat: enable step actions by default

Author: waveywaves

config/config-feature-flags.yaml

@@ -124,9 +124,8 @@ data:
   keep-pod-on-cancel: "false"
   # Setting this flag to "true" will enable the CEL evaluation in WhenExpression
   enable-cel-in-whenexpression: "false"
-  # Setting this flag to "true" will enable the use of StepActions in Steps
-  # This feature is in preview mode and not implemented yet. Please check #7259 for updates.
-  enable-step-actions: "false"
+  # Setting this flag to "true" will enable the use of StepActions in Steps.
+  enable-step-actions: "true"
   # Setting this flag to "true" will enable the use of Artifacts in Steps
   # This feature is in preview mode and not implemented yet. Please check #7693 for updates.
   enable-artifacts: "false"

docs/stepactions.md

@@ -22,7 +22,7 @@ weight: 201
 
 ## Overview
 > :seedling: **`StepActions` is an [beta](additional-configs.md#beta-features) feature.**
-> The `enable-step-actions` feature flag must be set to `"true"` to specify a `StepAction` in a `Step`.
+> Step actions are enabled by default. You can disable them by setting the `enable-step-actions` feature flag to `"false"`.
 
 A `StepAction` is the reusable and scriptable unit of work that is performed by a `Step`.
 

pkg/apis/config/feature_flags.go

@@ -156,8 +156,8 @@ var (
 	// DefaultEnableStepActions is the default PerFeatureFlag value for EnableStepActions
 	DefaultEnableStepActions = PerFeatureFlag{
 		Name:      EnableStepActions,
-		Stability: BetaAPIFields,
-		Enabled:   DefaultBetaFeatureEnabled,
+		Stability: StableAPIFields,
+		Enabled:   DefaultStableFeatureEnabled,
 	}
 
 	// DefaultEnableArtifacts is the default PerFeatureFlag value for EnableArtifacts

pkg/apis/config/feature_flags_test.go

@@ -132,6 +132,7 @@ func TestNewFeatureFlagsFromConfigMap(t *testing.T) {
 				SetSecurityContext:               config.DefaultSetSecurityContext,
 				Coschedule:                       config.DefaultCoschedule,
 				EnableParamEnum:                  config.DefaultEnableParamEnum.Enabled,
+				EnableStepActions:                config.DefaultEnableStepActions.Enabled,
 				DisableInlineSpec:                config.DefaultDisableInlineSpec,
 			},
 			fileName: "feature-flags-bundles-and-custom-tasks",
@@ -153,6 +154,7 @@ func TestNewFeatureFlagsFromConfigMap(t *testing.T) {
 				SetSecurityContext:               config.DefaultSetSecurityContext,
 				Coschedule:                       config.DefaultCoschedule,
 				EnableParamEnum:                  config.DefaultEnableParamEnum.Enabled,
+				EnableStepActions:                config.DefaultEnableStepActions.Enabled,
 				DisableInlineSpec:                config.DefaultDisableInlineSpec,
 			},
 			fileName: "feature-flags-beta-api-fields",

pkg/apis/config/testdata/feature-flags-beta-api-fields.yaml

@@ -4,4 +4,5 @@ metadata:
   name: feature-flags
   namespace: tekton-pipelines
 data:
-  enable-api-fields: "beta"
+  enable-api-fields: "beta"
+  enable-step-actions: "true"

pkg/apis/config/testdata/feature-flags-bundles-and-custom-tasks.yaml

@@ -7,3 +7,4 @@ data:
   enable-tekton-oci-bundles: "true"
   enable-custom-tasks: "true"
   enable-api-fields: "stable"
+  enable-step-actions: "true"

pkg/reconciler/taskrun/taskrun_test.go

@@ -1421,7 +1421,6 @@ metadata:
   namespace: foo
 spec:
   taskRef:
-    kind: ClusterTask
     name: taskrun-with-wrong-ref
 `)
 	taskRuns := []*v1.TaskRun{noTaskRun, withWrongRef}
@@ -1734,6 +1733,7 @@ status:
         maxResultSize: 4096
         coschedule: "workspaces"
         disableInlineSpec: ""
+        enableStepActions: true
   provenance:
     featureFlags:
       runningInEnvWithInjectedSidecars: true
@@ -1746,6 +1746,7 @@ status:
       maxResultSize: 4096
       coschedule: "workspaces"
       disableInlineSpec: ""
+      enableStepActions: true
 `, pipelineErrors.UserErrorLabel, pipelineErrors.UserErrorLabel))
 		reconciliatonError = errors.New("1 error occurred:\n\t* Provided results don't match declared results; may be invalid JSON or missing result declaration:  \"aResult\": task result is expected to be \"array\" type but was initialized to a different type \"string\"")
 		toBeRetriedTaskRun = parse.MustParseV1TaskRun(t, `
@@ -1800,6 +1801,7 @@ status:
       maxResultSize: 4096
       coschedule: "workspaces"
       disableInlineSpec: ""
+      enableStepActions: true
 `)
 		toBeRetriedWithResultsTaskRun = parse.MustParseV1TaskRun(t, `
 metadata:
@@ -1903,7 +1905,8 @@ status:
 			ConfigMaps: []*corev1.ConfigMap{{
 				ObjectMeta: metav1.ObjectMeta{Namespace: system.Namespace(), Name: config.GetFeatureFlagsConfigName()},
 				Data: map[string]string{
-					"enable-api-fields": config.AlphaAPIFields,
+					"enable-step-actions": "true",
+					"enable-api-fields":   config.AlphaAPIFields,
 				},
 			}},
 		},

test/e2e-tests-kind-prow-feature-flags.env

@@ -5,7 +5,7 @@ RUN_YAML_TESTS=false
 KO_DOCKER_REPO=registry.local:5000
 RUN_FEATUREFLAG_TESTS=true
 E2E_GO_TEST_TIMEOUT=60m
-ENABLE_STEP_ACTIONS=false
+ENABLE_STEP_ACTIONS=true
 ENABLE_CEL_IN_WHENEXPRESSION=false
 ENABLE_PARAM_ENUM=false
 KEEP_POD_ON_CANCEL=false

test/e2e-tests.sh

@@ -28,7 +28,7 @@ SKIP_GO_E2E_TESTS=${SKIP_GO_E2E_TESTS:="false"}
 E2E_GO_TEST_TIMEOUT=${E2E_GO_TEST_TIMEOUT:="20m"}
 RUN_FEATUREFLAG_TESTS=${RUN_FEATUREFLAG_TESTS:="false"}
 RESULTS_FROM=${RESULTS_FROM:-termination-message}
-ENABLE_STEP_ACTIONS=${ENABLE_STEP_ACTIONS:="false"}
+ENABLE_STEP_ACTIONS=${ENABLE_STEP_ACTIONS:="true"}
 ENABLE_CEL_IN_WHENEXPRESSION=${ENABLE_CEL_IN_WHENEXPRESSION:="false"}
 ENABLE_PARAM_ENUM=${ENABLE_PARAM_ENUM:="false"}
 ENABLE_ARTIFACTS=${ENABLE_ARTIFACTS:="false"}

test/taskrun_test.go

@@ -610,7 +610,10 @@ func TestTaskRunResolveDefaultParameterSubstitutionOnStepAction(t *testing.T) {
 	ctx, cancel := context.WithCancel(ctx)
 	defer cancel()
 
-	c, namespace := setup(ctx, t, requireAllGates(requireEnableStepActionsGate))
+	c, namespace := setup(ctx, t, requireAllGates(map[string]string{
+		"enable-step-actions": "true",
+		"enable-api-fields":   "beta",
+	}))
 
 	knativetest.CleanupOnInterrupt(func() { tearDown(ctx, t, c, namespace) }, t.Logf)
 	defer tearDown(ctx, t, c, namespace)