cleanup: use better names for the credentials interfaces

Author: waveywaves

cmd/entrypoint/main.go

@@ -96,7 +96,7 @@ func main() {
 	// from secret volume mounts to /tekton/creds. This is done to support the expansion
 	// of a variable, $(credentials.path), that resolves to a single place with all the
 	// stored credentials.
-	builders := []credwriter.Builder{dockercreds.NewBuilder(), gitcreds.NewBuilder()}
+	builders := []credwriter.Writer{dockercreds.NewBuilder(), gitcreds.NewBuilder()}
 	for _, c := range builders {
 		if err := c.Write(pipeline.CredsDir); err != nil {
 			log.Printf("Error initializing credentials: %s", err)

pkg/credentials/dockercreds/creds.go

@@ -145,8 +145,8 @@ type basicDockerBuilder struct{}
 
 // NewBuilder returns a new builder for Docker credentials.
 func NewBuilder() interface {
-	credmatcher.Builder
-	credwriter.Builder
+	credmatcher.Matcher
+	credwriter.Writer
 } {
 	return &basicDockerBuilder{}
 }

pkg/credentials/gitcreds/creds.go

@@ -53,8 +53,8 @@ type gitBuilder struct{}
 
 // NewBuilder returns a new builder for Git credentials.
 func NewBuilder() interface {
-	credmatcher.Builder
-	credwriter.Builder
+	credmatcher.Matcher
+	credwriter.Writer
 } {
 	return &gitBuilder{}
 }

pkg/credentials/matcher/matcher.go

@@ -26,8 +26,8 @@ import (
 // It is mutable and exported for testing.
 var VolumePath = "/tekton/creds-secrets"
 
-// Builder is the interface for a credential initializer of any type.
-type Builder interface {
+// Matcher is the interface for a credential initializer of any type.
+type Matcher interface {
 	// MatchingAnnotations extracts flags for the credential
 	// helper from the supplied secret and returns a slice (of
 	// length 0 or greater) of applicable domains.

pkg/credentials/writer/writer.go

@@ -43,8 +43,8 @@ const (
 // helper (aka "creds-init") can write to /tekton/creds.
 var CredsInitCredentials = []string{".docker", ".gitconfig", ".git-credentials", ".ssh"}
 
-// Builder is the interface for a credential initializer of any type.
-type Builder interface {
+// Writer is the interface for a credential initializer of any type.
+type Writer interface {
 	// Write writes the credentials to the provided directory.
 	Write(folder string) error
 }

pkg/pod/creds_init.go

@@ -76,8 +76,8 @@ func credsInit(ctx context.Context, obj runtime.Object, serviceAccountName, name
 	}
 
 	builders := []interface {
-		credmatcher.Builder
-		credwriter.Builder
+		credmatcher.Matcher
+		credwriter.Writer
 	}{dockercreds.NewBuilder(), gitcreds.NewBuilder()}
 
 	var volumeMounts []corev1.VolumeMount