Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: allow users apart from ones with write permissions to trigger /retest #8621

Open
2 tasks
waveywaves opened this issue Mar 4, 2025 · 4 comments
Open
2 tasks

Comments

@waveywaves
Copy link
Member

waveywaves commented Mar 4, 2025

Currently users with only write permissions can trigger retests with the /retest flag. collaborator folk such as myself have to rely on maintainer intervention to ensure that flakes aren't giving false positives wrt if the test is failing. Being able to hit the /retest will allow users to develop more easily on the repository. Initially we can allow collaborators to user /retest. Afterwards we can introduce /ok-to-test to mark PRs which will allow outside collaborators to contribute and use /retest without unnecessary intervention.

  • implement /retest for collaborators
  • implement /ok-to-test for wider audience as a boolean check which will then allow the outside contributor to user /retest

based on discussions in #8616 (comment)

@leshikus
Copy link

leshikus commented Mar 6, 2025

I believe adding workflow_dispatch should resolve this as well. #8624

@AlanGreene
Copy link
Member

@leshikus workflow_dispatch still requires write permissions.

See https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/manually-running-a-workflow#configuring-a-workflow-to-run-manually

Write access to the repository is required to perform these steps.

@leshikus
Copy link

I was able to run tests with workflow_dispatch in my own fork

still requires write permissions.

@AlanGreene
Copy link
Member

AlanGreene commented Mar 18, 2025

Yes as you have write permissions on your fork, you own that repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

3 participants