Skip to content

Commit c1741bf

Browse files
committed
only allow deposit and withdraw to msg sender
1 parent 08a1fc7 commit c1741bf

3 files changed

Lines changed: 63 additions & 2 deletions

File tree

packages/contracts/contracts/LenderCommitmentForwarder/extensions/LenderCommitmentGroup/LenderCommitmentGroup_Pool_V2.sol

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1301,6 +1301,7 @@ contract LenderCommitmentGroup_Pool_V2 is
13011301

13021302
// Similar to addPrincipalToCommitmentGroup but following ERC4626 standard
13031303
require(assets > 0 );
1304+
require( msg.sender == receiver );
13041305

13051306
bool poolWasActivated = poolIsActivated();
13061307

@@ -1351,6 +1352,8 @@ contract LenderCommitmentGroup_Pool_V2 is
13511352
assets = previewMint(shares);
13521353
require(assets > 0);
13531354

1355+
require( msg.sender == receiver );
1356+
13541357

13551358
bool poolWasActivated = poolIsActivated();
13561359

packages/contracts/tests/SmartCommitmentForwarder/LenderCommitmentGroup_Pool_V2_Test.sol

Lines changed: 56 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -364,6 +364,62 @@ contract LenderCommitmentGroup_Pool_V2_Test is Testable {
364364
}
365365

366366

367+
368+
369+
370+
371+
// ERC4626 Vault Tests
372+
/* function test_erc4626_deposit_resets_shares_delay() public {
373+
initialize_group_contract();
374+
lenderCommitmentGroupSmartV2.set_mockSharesExchangeRate(1e36);
375+
376+
lenderCommitmentGroupSmartV2.set_mockPoolIsActivated(true);
377+
378+
vm.prank(address(lender));
379+
principalToken.approve(address(lenderCommitmentGroupSmartV2), 1000000);
380+
381+
382+
383+
uint256 originalTime = block.timestamp;
384+
vm.warp( originalTime + 5000000);
385+
386+
387+
388+
389+
address recipient = address(liquidator);
390+
391+
vm.prank(address(lender));
392+
uint256 sharesAmount = lenderCommitmentGroupSmartV2.deposit(1000000, address(recipient));
393+
394+
uint256 expectedSharesAmount = 1000000;
395+
assertEq(
396+
sharesAmount,
397+
expectedSharesAmount,
398+
"Received an unexpected amount of shares"
399+
);
400+
401+
402+
403+
404+
uint256 sharesLastTransferredAt = lenderCommitmentGroupSmartV2
405+
.getSharesLastTransferredAt(address(recipient));
406+
407+
assertEq(
408+
originalTime + 5000000,
409+
sharesLastTransferredAt,
410+
"Received an unexpected amount of shares"
411+
);
412+
413+
}*/
414+
415+
416+
417+
418+
419+
420+
421+
422+
367423
function test_erc4626_accounting() public {
368424
initialize_group_contract();
369425

packages/subgraph-pool-v2/README.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,13 +74,15 @@ graph deploy tellerv2-poolsv2-mainnet \
7474
deploy to goldsky
7575
7676
77+
npm run codegen && npm run build
78+
7779
npm run generate katana
7880
7981
npm run generate hyperevm
8082
81-
goldsky subgraph deploy teller-pools-v2-hyperevm/0.4.21.2
83+
goldsky subgraph deploy teller-pools-v2-hyperevm/0.4.21.10
8284
83-
goldsky subgraph deploy teller-pools-v2-katana/0.4.21.9
85+
goldsky subgraph deploy teller-pools-v2-katana/0.4.21.10
8486
8587
8688
```

0 commit comments

Comments
 (0)