Skip to content

Commit b160fb0

Browse files
authored
improve error messages in RpcRetryOptions (#2708)
1 parent f864e8a commit b160fb0

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

temporal-serviceclient/src/main/java/io/temporal/serviceclient/RpcRetryOptions.java

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ private Builder(RpcRetryOptions options) {
107107
*/
108108
public Builder setInitialInterval(Duration initialInterval) {
109109
if (isInvalidDuration(initialInterval)) {
110-
throw new IllegalArgumentException("invalid interval: " + initialInterval);
110+
throw new IllegalArgumentException("invalid initialInterval: " + initialInterval);
111111
}
112112
this.initialInterval = initialInterval;
113113
return this;
@@ -122,7 +122,8 @@ public Builder setInitialInterval(Duration initialInterval) {
122122
*/
123123
public Builder setCongestionInitialInterval(Duration congestionInitialInterval) {
124124
if (isInvalidDuration(congestionInitialInterval)) {
125-
throw new IllegalArgumentException("invalid interval: " + congestionInitialInterval);
125+
throw new IllegalArgumentException(
126+
"invalid congestionInitialInterval: " + congestionInitialInterval);
126127
}
127128
this.congestionInitialInterval = congestionInitialInterval;
128129
return this;
@@ -139,7 +140,7 @@ public Builder setCongestionInitialInterval(Duration congestionInitialInterval)
139140
*/
140141
public Builder setExpiration(Duration expiration) {
141142
if (isInvalidDuration(expiration)) {
142-
throw new IllegalArgumentException("invalid interval: " + expiration);
143+
throw new IllegalArgumentException("invalid expiration : " + expiration);
143144
}
144145
this.expiration = expiration;
145146
return this;
@@ -155,7 +156,7 @@ public Builder setExpiration(Duration expiration) {
155156
public Builder setBackoffCoefficient(double backoffCoefficient) {
156157
if (isInvalidBackoffCoefficient(backoffCoefficient)) {
157158
throw new IllegalArgumentException(
158-
"coefficient must be >= 1.0 and finite: " + backoffCoefficient);
159+
"backoffCoefficient must be >= 1.0 and finite: " + backoffCoefficient);
159160
}
160161
this.backoffCoefficient = backoffCoefficient;
161162
return this;
@@ -189,7 +190,7 @@ public Builder setMaximumAttempts(int maximumAttempts) {
189190
*/
190191
public Builder setMaximumInterval(Duration maximumInterval) {
191192
if (isInvalidDuration(maximumInterval)) {
192-
throw new IllegalArgumentException("invalid interval: " + maximumInterval);
193+
throw new IllegalArgumentException("invalid maximumInterval: " + maximumInterval);
193194
}
194195
this.maximumInterval = maximumInterval;
195196
return this;
@@ -204,7 +205,7 @@ public Builder setMaximumInterval(Duration maximumInterval) {
204205
public Builder setMaximumJitterCoefficient(double maximumJitterCoefficient) {
205206
if (isInvalidJitterCoefficient(maximumJitterCoefficient)) {
206207
throw new IllegalArgumentException(
207-
"coefficient must be >= 0 and < 1.0: " + maximumJitterCoefficient);
208+
"maximumJitterCoefficient must be >= 0 and < 1.0: " + maximumJitterCoefficient);
208209
}
209210
this.maximumJitterCoefficient = maximumJitterCoefficient;
210211
return this;
@@ -468,7 +469,7 @@ public void validate(boolean hasToBeFinite) {
468469
+ initialInterval);
469470
}
470471
if (backoffCoefficient != 0d && backoffCoefficient < 1.0) {
471-
throw new IllegalArgumentException("coefficient less than 1");
472+
throw new IllegalArgumentException("backoffCoefficient less than 1");
472473
}
473474
if (!Double.isFinite(maximumJitterCoefficient)
474475
|| maximumJitterCoefficient < 0

0 commit comments

Comments
 (0)