Skip to content

Commit 1a68b58

Browse files
authored
More precise logging (#734)
1 parent bd44efa commit 1a68b58

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

.github/workflows/ci.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -53,13 +53,13 @@ jobs:
5353
- run: poe lint
5454
- run: poe build-develop
5555
- run: mkdir junit-xml
56-
- run: poe test -s -o log_cli_level=DEBUG --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
56+
- run: poe test -s --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
5757
# Time skipping doesn't yet support ARM
5858
- if: ${{ !endsWith(matrix.os, '-arm') }}
59-
run: poe test -s -o log_cli_level=DEBUG --workflow-environment time-skipping --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}--time-skipping.xml
59+
run: poe test -s --workflow-environment time-skipping --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}--time-skipping.xml
6060
# Check cloud if proper target and not on fork
6161
- if: ${{ matrix.cloudTestTarget && (github.event.pull_request.head.repo.full_name == '' || github.event.pull_request.head.repo.full_name == 'temporalio/sdk-python') }}
62-
run: poe test -s -o log_cli_level=DEBUG -k test_cloud_client --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}--cloud.xml
62+
run: poe test -s -k test_cloud_client --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}--cloud.xml
6363
env:
6464
TEMPORAL_CLIENT_CLOUD_API_KEY: ${{ secrets.TEMPORAL_CLIENT_CLOUD_API_KEY }}
6565
TEMPORAL_CLIENT_CLOUD_API_VERSION: 2024-05-13-00
@@ -87,7 +87,7 @@ jobs:
8787
poe gen-protos
8888
poe format
8989
[[ -z $(git status --porcelain temporalio) ]] || (git diff temporalio; echo "Protos changed"; exit 1)
90-
poe test -s -o log_cli_level=DEBUG
90+
poe test -s
9191
9292
# Do docs stuff (only on one host)
9393
- name: Build API docs

pyproject.toml

+4-3
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,10 @@ cmd = "pip uninstall temporalio -y"
105105

106106
[tool.pytest.ini_options]
107107
asyncio_mode = "auto"
108-
log_cli = true
109-
log_cli_level = "INFO"
110-
log_cli_format = "%(asctime)s [%(levelname)8s] %(message)s (%(filename)s:%(lineno)s)"
108+
# Do not use log_cli since this shows logging for all tests, not just the ones
109+
# that failed. Instead, show all logs for failed tests at the end.
110+
log_level = "DEBUG"
111+
log_format = "%(asctime)s [%(levelname)8s] %(message)s (%(filename)s:%(lineno)s)"
111112
testpaths = ["tests"]
112113
timeout = 600
113114
timeout_func_only = true

0 commit comments

Comments
 (0)