Remove exposure of skip_client_worker_set_check

Author: yuandrew

temporalio/bridge/src/worker.rs

@@ -65,7 +65,6 @@ pub struct WorkerConfig {
     nondeterminism_as_workflow_fail_for_types: HashSet<String>,
     nexus_task_poller_behavior: PollerBehavior,
     plugins: Vec<String>,
-    skip_client_worker_set_check: bool,
 }
 
 #[derive(FromPyObject)]
@@ -735,7 +734,6 @@ fn convert_worker_config(
                 })
                 .collect::<Vec<_>>(),
         )
-        .skip_client_worker_set_check(conf.skip_client_worker_set_check)
         .build()
         .map_err(|err| PyValueError::new_err(format!("Invalid worker config: {err}")))
 }

temporalio/bridge/worker.py

@@ -65,7 +65,6 @@ class WorkerConfig:
     nondeterminism_as_workflow_fail_for_types: Set[str]
     nexus_task_poller_behavior: PollerBehavior
     plugins: Sequence[str]
-    skip_client_worker_set_check: bool
 
 
 @dataclass

temporalio/worker/_replayer.py

@@ -294,7 +294,6 @@ def on_eviction_hook(
                         1
                     ),
                     plugins=[plugin.name() for plugin in self.plugins],
-                    skip_client_worker_set_check=True,
                 ),
             )
             # Start worker

temporalio/worker/_worker.py

@@ -148,7 +148,6 @@ def __init__(
         nexus_task_poller_behavior: PollerBehavior = PollerBehaviorSimpleMaximum(
             maximum=5
         ),
-        skip_client_worker_set_check: bool = False,
     ) -> None:
         """Create a worker to process workflows and/or activities.
 
@@ -323,9 +322,6 @@ def __init__(
                 Defaults to a 5-poller maximum.
             nexus_task_poller_behavior: Specify the behavior of Nexus task polling.
                 Defaults to a 5-poller maximum.
-            skip_client_worker_set_check: Skip the runtime validation that ensures
-                the client is registered with the worker set. This should only be
-                used in tests.
         """
         config = WorkerConfig(
             client=client,
@@ -368,7 +364,6 @@ def __init__(
             workflow_task_poller_behavior=workflow_task_poller_behavior,
             activity_task_poller_behavior=activity_task_poller_behavior,
             nexus_task_poller_behavior=nexus_task_poller_behavior,
-            skip_client_worker_set_check=skip_client_worker_set_check,
         )
 
         plugins_from_client = cast(
@@ -620,7 +615,6 @@ def check_activity(activity):
                     "nexus_task_poller_behavior"
                 ]._to_bridge(),
                 plugins=plugins,
-                skip_client_worker_set_check=config["skip_client_worker_set_check"],
             ),
         )
 
@@ -915,7 +909,6 @@ class WorkerConfig(TypedDict, total=False):
     activity_task_poller_behavior: PollerBehavior
     nexus_task_poller_behavior: PollerBehavior
     plugins: Sequence[Plugin]
-    skip_client_worker_set_check: bool
 
 
 def _warn_if_activity_executor_max_workers_is_inconsistent(

tests/conftest.py

@@ -59,18 +59,6 @@ def pytest_addoption(parser):
     )
 
 
-@pytest.fixture(autouse=True)
-def _skip_client_worker_set_check(monkeypatch):
-    original_init = temporalio.worker.Worker.__init__
-
-    def patched_init(self, *args, **kwargs):
-        kwargs.setdefault("skip_client_worker_set_check", True)
-        return original_init(self, *args, **kwargs)
-
-    monkeypatch.setattr(temporalio.worker.Worker, "__init__", patched_init)
-    yield
-
-
 @pytest.fixture(scope="session")
 def event_loop():
     loop = asyncio.get_event_loop_policy().new_event_loop()