Fix more type errors #977
Fix more type errors #977
Conversation
temporalio/common.py
Outdated
| @@ -729,7 +729,7 @@ def with_additional_attributes( | |||
| ... | |||
|
|
|||
|
|
|||
| class MetricCounter(MetricCommon): | |||
| class MetricCounter(MetricCommon, ABC): | |||
There was a problem hiding this comment.
This is interesting. Is re-inheriting ABC at every level a general Python preference or just a preference of a certain tool?
There was a problem hiding this comment.
Pyright was telling us to do it since they were effectively still ABCs
https://docs.basedpyright.com/v1.31.0/configuration/config-files/#reportImplicitAbstractClass
We can disable any we don't like, but I was thinking that we should err on the side of going with them.
There was a problem hiding this comment.
Hm, actually that's basedpyright-specific. I'm going to revert it.
| **_WorkflowExternFunctions( | ||
| __temporal_opentelemetry_completed_span=self._completed_workflow_span, | ||
| ) | ||
| { | ||
| "__temporal_opentelemetry_completed_span": self._completed_workflow_span, | ||
| } |
There was a problem hiding this comment.
What is the harm in using the constructor form of the TypedDict here instead of the dict literal with string literals?
There was a problem hiding this comment.
I couldn't see how to make it work with pyright (and your comment already indicated mypy probelems)
$ uv run pyright
/Users/dan/src/temporalio/sdk-python/temporalio/contrib/opentelemetry.py
/Users/dan/src/temporalio/sdk-python/temporalio/contrib/opentelemetry.py:130:15 - error: Argument of type "object" cannot be assigned to parameter "kwargs" of type "(...) -> Unknown" in function "update"
Type "object" is not assignable to type "(...) -> Unknown" (reportArgumentType)
There was a problem hiding this comment.
Yeah, unfortunate that we can't use that nice constructor-like kwarg approach afforded to us by typed dicts
dandavison
force-pushed
the
dan-0004-no-more-type-errors
branch
from
b9e35ed to
382ee2c
Compare
Paramaterize OpenAI agents with context type in test
dandavison
force-pushed
the
dan-0004-no-more-type-errors
branch
from
382ee2c to
621525c
Compare
Miscellaneous type error fixes, making progress towards fixing them all, opening PR for this subset since this is how many got done right now and we don't want them to pick up conflicts.
Reviewers: the commit named "interesting" contains slightly more interesting fixes.