Code review feedback

Author: jlegrone

go.mod

@@ -14,7 +14,7 @@ require (
 	go.temporal.io/api v1.53.0
 	go.temporal.io/sdk v1.35.0
 	go.temporal.io/sdk/contrib/envconfig v0.1.0
-	go.temporal.io/server v1.29.0-142.0
+	go.temporal.io/server v1.28.1
 	k8s.io/api v0.34.0
 	k8s.io/apimachinery v0.34.0
 	k8s.io/client-go v0.34.0
@@ -152,6 +152,7 @@ require (
 	go.opentelemetry.io/otel/sdk/metric v1.34.0 // indirect
 	go.opentelemetry.io/otel/trace v1.34.0 // indirect
 	go.opentelemetry.io/proto/otlp v1.5.0 // indirect
+	go.temporal.io/version v0.3.0 // indirect
 	go.uber.org/atomic v1.11.0 // indirect
 	go.uber.org/dig v1.18.0 // indirect
 	go.uber.org/fx v1.23.0 // indirect

go.sum

@@ -386,8 +386,6 @@ github.com/zeebo/errs v1.4.0 h1:XNdoD/RRMKP7HD0UhJnIzUy74ISdGGxURlYG8HSWSfM=
 github.com/zeebo/errs v1.4.0/go.mod h1:sgbWHsvVuTPHcqJJGQ1WhI5KbWlHYz+2+2C/LSEtCw4=
 go.opentelemetry.io/auto/sdk v1.1.0 h1:cH53jehLUN6UFLY71z+NDOiNJqDdPRaXzTel0sJySYA=
 go.opentelemetry.io/auto/sdk v1.1.0/go.mod h1:3wSPjt5PWp2RhlCcmmOial7AvC4DQqZb7a7wCow3W8A=
-go.opentelemetry.io/collector/pdata v1.34.0 h1:2vwYftckXe7pWxI9mfSo+tw3wqdGNrYpMbDx/5q6rw8=
-go.opentelemetry.io/collector/pdata v1.34.0/go.mod h1:StPHMFkhLBellRWrULq0DNjv4znCDJZP6La4UuC+JHI=
 go.opentelemetry.io/contrib/detectors/gcp v1.34.0 h1:JRxssobiPg23otYU5SbWtQC//snGVIM3Tx6QRzlQBao=
 go.opentelemetry.io/contrib/detectors/gcp v1.34.0/go.mod h1:cV4BMFcscUR/ckqLkbfQmF0PRsq8w/lMGzdbCSveBHo=
 go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.59.0 h1:rgMkmiGfix9vFJDcDi1PK8WEQP4FLQwLDfhp5ZLpFeE=
@@ -422,8 +420,10 @@ go.temporal.io/sdk v1.35.0 h1:lRNAQ5As9rLgYa7HBvnmKyzxLcdElTuoFJ0FXM/AsLQ=
 go.temporal.io/sdk v1.35.0/go.mod h1:1q5MuLc2MEJ4lneZTHJzpVebW2oZnyxoIOWX3oFVebw=
 go.temporal.io/sdk/contrib/envconfig v0.1.0 h1:s+G/Ujph+Xl2jzLiiIm2T1vuijDkUL4Kse49dgDVGBE=
 go.temporal.io/sdk/contrib/envconfig v0.1.0/go.mod h1:FQEO3C56h9C7M6sDgSanB8HnBTmopw9qgVx4F1S6pJk=
-go.temporal.io/server v1.29.0-142.0 h1:8uCRD7xWzlEaiAaxj/rg/Y5iIXx3ggyjwwVZHATe8JY=
-go.temporal.io/server v1.29.0-142.0/go.mod h1:pc0n6DRcN06V4WNhaxdxE3KaZIS3KSDNKdca6uu6RuU=
+go.temporal.io/server v1.28.1 h1:koDHINsed1onr/TpLfYWINbTBmFQLRUfU5LtPlxjvLQ=
+go.temporal.io/server v1.28.1/go.mod h1:QcXPBkDo/WOwq3NPVrT4KsYczsgxvW0bKg489qPn0QU=
+go.temporal.io/version v0.3.0 h1:dMrei9l9NyHt8nG6EB8vAwDLLTwx2SvRyucCSumAiig=
+go.temporal.io/version v0.3.0/go.mod h1:UA9S8/1LaKYae6TyD9NaPMJTZb911JcbqghI2CBSP78=
 go.uber.org/atomic v1.5.0/go.mod h1:sABNBOSYdrvTF6hTgEIbc7YasKWGhgEQZyfxyTvoXHQ=
 go.uber.org/atomic v1.7.0/go.mod h1:fEN4uk6kAWBTFdckzkM89CLk9XfWZrxpCo0nPH17wJc=
 go.uber.org/atomic v1.11.0 h1:ZvwS0R+56ePWxUNi+Atn9dWONBPp/AUETXlHW0DxSjE=

internal/demo/helloworld/helm/helloworld/templates/deployment.yaml

@@ -1,4 +1,5 @@
-#file: noinspection KubernetesUnknownResourcesInspection
+# This template creates a TemporalWorkerDeployment custom resource that manages
+# the lifecycle of Temporal worker pods, including progressive rollouts and scaling
 apiVersion: temporal.io/v1alpha1
 kind: TemporalWorkerDeployment
 metadata:

hack/demo_commands.sh renamed to internal/demo/scripts/demo_commands.sh

@@ -36,6 +36,8 @@ func configureObservability(buildID string, metricsPort int) (l log.Logger, m op
 		InitialAttributes: attribute.NewSet(attribute.String("version", buildID)),
 	})
 
+	// TODO(jlegrone): Expose these metrics in the demo to show worker performance
+	// and rollout progress. Metrics include temporal_request_total, temporal_workflow_completed, etc.
 	go func() {
 		addr := fmt.Sprintf(":%d", metricsPort)
 		slogger.Info("Serving metrics", slog.String("address", fmt.Sprintf("localhost%s/metrics", addr)))

hack/git_stepper.sh renamed to internal/demo/scripts/git_stepper.sh

@@ -65,7 +65,7 @@ deploy:
     hooks:
       before:
         - host:
-            command: ["./hack/update_chart_version.sh"]
+            command: ["./internal/demo/scripts/update_chart_version.sh"]
       after:
         - host:
             command: ["sh", "-c", "sed -i '' 's/appVersion: .*/appVersion: \"automated\"/' internal/demo/helloworld/helm/helloworld/Chart.yaml"]