remove fastForwardNotifier from context provider

Author: feiyang3cat

common/testing/mocksdk/client_mock.go

@@ -47,7 +47,6 @@ import (
 	"go.temporal.io/server/service/history/consts"
 	"go.temporal.io/server/service/history/events"
 	"go.temporal.io/server/service/history/hsm"
-	"go.temporal.io/server/service/history/notification"
 	"go.temporal.io/server/service/history/replication"
 	"go.temporal.io/server/service/history/shard"
 	"go.temporal.io/server/service/history/workflow"
@@ -93,7 +92,6 @@ var Module = fx.Options(
 	service.PersistenceLazyLoadedServiceResolverModule,
 	fx.Provide(ServiceResolverProvider),
 	fx.Provide(EventNotifierProvider),
-	fx.Provide(TimeSkippingFastForwardNotifierProvider),
 	fx.Provide(HistoryEngineFactoryProvider),
 	fx.Provide(HandlerProvider),
 	fx.Provide(HistoryServiceServerProvider),
@@ -484,12 +482,6 @@ func EventNotifierProvider(
 	)
 }
 
-func TimeSkippingFastForwardNotifierProvider(
-	serviceConfig *configs.Config,
-) notification.TimeSkippingFastForwardNotifier {
-	return notification.NewTimeSkippingFastForwardNotifier(serviceConfig.GetShardID)
-}
-
 func ServiceLifetimeHooks(lc fx.Lifecycle, svc *Service) {
 	lc.Append(fx.StartStopHook(svc.Start, svc.Stop))
 }

service/history/fx.go

@@ -161,7 +161,6 @@ func NewEngineWithShardContext(
 	matchingClient matchingservice.MatchingServiceClient,
 	sdkClientFactory sdk.ClientFactory,
 	eventNotifier events.Notifier,
-	fastForwardNotifier notification.TimeSkippingFastForwardNotifier,
 	config *configs.Config,
 	versionCache worker_versioning.VersionMembershipAndReactivationStatusCache,
 	workerDeploymentClient workerdeployment.Client,
@@ -218,7 +217,7 @@ func NewEngineWithShardContext(
 		throttledLogger:            log.With(shard.GetThrottledLogger(), tag.ComponentHistoryEngine),
 		metricsHandler:             shard.GetMetricsHandler(),
 		eventNotifier:              eventNotifier,
-		fastForwardNotifier:        fastForwardNotifier,
+		fastForwardNotifier:        notification.NewTimeSkippingFastForwardNotifier(config.GetShardID),
 		config:                     config,
 		sdkClientFactory:           sdkClientFactory,
 		matchingClient:             matchingClient,
@@ -895,7 +894,7 @@ func (e *historyEngineImpl) NotifyFastForwardUpdate(
 	fastforwardNotification *notification.TimeSkippingFastForwardNotification,
 ) {
 	if e.fastForwardNotifier == nil {
-		// Always injected in production via fx; a nil here means a misconfigured engine.
+		// Always set by NewEngineWithShardContext; a nil here means a hand-built engine.
 		// Fast-forward notification is best-effort (waiters re-poll on timeout), so log and
 		// skip rather than panic.
 		e.logger.Warn("fastForwardNotifier is not configured; skipping fast-forward notification",

service/history/history_engine.go

@@ -17,7 +17,6 @@ import (
 	"go.temporal.io/server/service/history/configs"
 	"go.temporal.io/server/service/history/events"
 	historyi "go.temporal.io/server/service/history/interfaces"
-	"go.temporal.io/server/service/history/notification"
 	"go.temporal.io/server/service/history/replication"
 	"go.temporal.io/server/service/history/tasks"
 	"go.temporal.io/server/service/history/workflow"
@@ -34,7 +33,6 @@ type (
 		MatchingClient                  resource.MatchingClient
 		SdkClientFactory                sdk.ClientFactory
 		EventNotifier                   events.Notifier
-		TimeSkippingFastForwardNotifier notification.TimeSkippingFastForwardNotifier
 		Config                          *configs.Config
 		RawMatchingClient               resource.MatchingRawClient
 		WorkflowCache                   wcache.Cache
@@ -73,7 +71,6 @@ func (f *historyEngineFactory) CreateEngine(
 		f.MatchingClient,
 		f.SdkClientFactory,
 		f.EventNotifier,
-		f.TimeSkippingFastForwardNotifier,
 		f.Config,
 		f.VersionMembershipCache,
 		f.WorkerDeploymentClient,