rename and remove stop reason

Author: feiyang3cat

api/persistence/v1/executions.pb.go

@@ -66,7 +66,7 @@ require (
 	go.opentelemetry.io/otel/sdk v1.43.0
 	go.opentelemetry.io/otel/sdk/metric v1.43.0
 	go.opentelemetry.io/otel/trace v1.44.0
-	go.temporal.io/api v1.63.4-0.20260723223619-864714b47375
+	go.temporal.io/api v1.63.4-0.20260723233445-8c30a7d77076
 	go.temporal.io/auto-scaled-workers v0.0.0-20260706201056-4320b34799ee
 	go.temporal.io/sdk v1.41.1
 	go.uber.org/fx v1.24.0

go.mod

@@ -483,6 +483,8 @@ go.temporal.io/api v1.63.4-0.20260722170540-d887973f0ebc h1:u6NNX5K5XdLqUbbruFMq
 go.temporal.io/api v1.63.4-0.20260722170540-d887973f0ebc/go.mod h1:SrlW2JMwVlDP4nRWSNznUFqnSHd+YeMDS1BkYo63HCQ=
 go.temporal.io/api v1.63.4-0.20260723223619-864714b47375 h1:5vDQEcw7PwikqfX9DdYOig7/9XoxQ1dgqj3L9Pr4TK0=
 go.temporal.io/api v1.63.4-0.20260723223619-864714b47375/go.mod h1:SrlW2JMwVlDP4nRWSNznUFqnSHd+YeMDS1BkYo63HCQ=
+go.temporal.io/api v1.63.4-0.20260723233445-8c30a7d77076 h1:cNdopy1sVIINkLFeR7DZfcYmzYNuxLMm9bhwLFNIplE=
+go.temporal.io/api v1.63.4-0.20260723233445-8c30a7d77076/go.mod h1:SrlW2JMwVlDP4nRWSNznUFqnSHd+YeMDS1BkYo63HCQ=
 go.temporal.io/auto-scaled-workers v0.0.0-20260706201056-4320b34799ee h1:y6A65Iml06cR3CpxW2Zn8FQLjniPDTnN4jtr69UZxXI=
 go.temporal.io/auto-scaled-workers v0.0.0-20260706201056-4320b34799ee/go.mod h1:hhHijO9XRPIkAflLJJHix61M9FzbRPqk8fSydkcLkqw=
 go.temporal.io/sdk v1.41.1 h1:yOpvsHyDD1lNuwlGBv/SUodCPhjv9nDeC9lLHW/fJUA=

go.sum

@@ -342,10 +342,6 @@ message TimeSkippingInfo {
   // Tracks the number of times a time-skipping transition has occurred since time skipping
   // was most recently enabled. It is reset every time the skipping config is updated.
   int32 session_skip_count = 6;
-
-  // Why time skipping most recently stopped running. Set when skipping transitions from running to
-  // stopped (user disabled it, a fast-forward completed, or the per-session skip cap was reached).
-  temporal.api.enums.v1.TimeSkippingStopReason stop_reason = 7;
 }
 
 message FastForwardInfo {

proto/internal/temporal/server/api/persistence/v1/executions.proto

@@ -714,9 +714,9 @@ func (wh *WorkflowHandler) validateAndPopulateTimeSkippingConfig(
 			ns.String(),
 		)
 	}
-	if tsc.GetMaxSkipPerSession() <= 0 {
+	if tsc.GetMaxSessionSkipCount() <= 0 {
 		defaultMaxSkipPerSession := wh.config.WorkflowTimeSkippingMaxSkipPerSession(ns.String())
-		tsc.MaxSkipPerSession = max(1, int32(defaultMaxSkipPerSession))
+		tsc.MaxSessionSkipCount = max(1, int32(defaultMaxSkipPerSession))
 	}
 
 	if !tsc.GetEnabled() {

service/frontend/workflow_handler.go

@@ -3724,17 +3724,17 @@ func (s *WorkflowHandlerSuite) TestValidateTimeSkippingConfig() {
 	// namespace with a per-namespace override uses that value
 	tsc := &commonpb.TimeSkippingConfig{Enabled: true}
 	s.Require().NoError(maxSkipWH.validateAndPopulateTimeSkippingConfig(tsc, s.testNamespace))
-	s.Require().Equal(int32(7), tsc.GetMaxSkipPerSession())
+	s.Require().Equal(int32(7), tsc.GetMaxSessionSkipCount())
 
 	// namespace without a per-namespace setting falls back to the per-cell value
 	tsc = &commonpb.TimeSkippingConfig{Enabled: true}
 	s.Require().NoError(maxSkipWH.validateAndPopulateTimeSkippingConfig(tsc, namespace.Name(otherNamespace)))
-	s.Require().Equal(int32(42), tsc.GetMaxSkipPerSession())
+	s.Require().Equal(int32(42), tsc.GetMaxSessionSkipCount())
 
 	// a value already on the request is preserved, not overwritten by dynamic config
-	tsc = &commonpb.TimeSkippingConfig{Enabled: true, MaxSkipPerSession: 999}
+	tsc = &commonpb.TimeSkippingConfig{Enabled: true, MaxSessionSkipCount: 999}
 	s.Require().NoError(maxSkipWH.validateAndPopulateTimeSkippingConfig(tsc, s.testNamespace))
-	s.Require().Equal(int32(999), tsc.GetMaxSkipPerSession())
+	s.Require().Equal(int32(999), tsc.GetMaxSessionSkipCount())
 }
 
 // TestExecuteMultiOperation_TimeSkipping_DCDisabled verifies that when the DC gate is off,

service/frontend/workflow_handler_test.go

@@ -6,7 +6,6 @@ import (
 	"time"
 
 	commonpb "go.temporal.io/api/common/v1"
-	enumspb "go.temporal.io/api/enums/v1"
 	historypb "go.temporal.io/api/history/v1"
 	"go.temporal.io/api/serviceerror"
 	persistencespb "go.temporal.io/server/api/persistence/v1"
@@ -54,9 +53,6 @@ func (ms *MutableStateImpl) updateTimeSkippingInfo(
 		return
 	}
 	ms.executionInfo.TimeSkippingInfo.Config = config
-	if !config.GetEnabled() {
-		tsi.StopReason = enumspb.TIME_SKIPPING_STOP_REASON_USER_DISABLED
-	}
 	ms.applyFastForward(nil)
 	ms.timeSkippingInfoUpdated = true
 	tsi.SessionSkipCount = 0
@@ -191,8 +187,8 @@ func propagateTimeSkippingToChild(
 
 	// propagate both config and state
 	return &commonpb.TimeSkippingConfig{
-		Enabled:           true,
-		MaxSkipPerSession: tsc.GetMaxSkipPerSession(),
+		Enabled:             true,
+		MaxSessionSkipCount: tsc.GetMaxSessionSkipCount(),
 	}, stateProp
 }
 
@@ -338,7 +334,7 @@ func (util *TimeSkippingInfoUtil) IsRunning(now time.Time) bool {
 	if util == nil || util.tsi == nil {
 		return false
 	}
-	hasSkipQuota := util.tsi.Config.GetMaxSkipPerSession() > util.tsi.GetSessionSkipCount()
+	hasSkipQuota := util.tsi.Config.GetMaxSessionSkipCount() > util.tsi.GetSessionSkipCount()
 	if !hasSkipQuota {
 		return false
 	}
@@ -361,7 +357,6 @@ func (util *TimeSkippingInfoUtil) ToDescribeInfo(currentTime time.Time) *commonp
 		CurrentTime:     timestamppb.New(currentTime),
 		IsRunning:       util.IsRunning(currentTime),
 		FastForwardInfo: util.ToFastForwardInfo(),
-		StopReason:      util.tsi.GetStopReason(),
 	}
 }
 
@@ -586,13 +581,11 @@ func (ms *MutableStateImpl) ApplyWorkflowExecutionTimeSkippingTransitionedEvent(
 	if attr.GetDisabledAfterFastForward() && tsi.GetFastForwardInfo() != nil {
 		tsi.GetFastForwardInfo().HasReached = true
 		tsi.Config.Enabled = false
-		tsi.StopReason = enumspb.TIME_SKIPPING_STOP_REASON_FAST_FORWARD_COMPLETED
 	}
 	// update skip
 	tsi.SessionSkipCount += 1
-	if tsi.SessionSkipCount >= tsi.Config.GetMaxSkipPerSession() && tsi.Config.Enabled {
+	if tsi.SessionSkipCount >= tsi.Config.GetMaxSessionSkipCount() && tsi.Config.Enabled {
 		tsi.Config.Enabled = false
-		tsi.StopReason = enumspb.TIME_SKIPPING_STOP_REASON_MAX_SKIP_PER_SESSION_REACHED
 	}
 
 	ms.timeSkippingInfoUpdated = true

service/history/workflow/timeskipping.go

@@ -152,35 +152,35 @@ func (s *mutableStateSuite) TestPropagateTimeSkippingToNextRun_FastForwardInfo()
 	s.Run("SkipCountAloneStillPropagates", func() {
 		tsc, stateProp := propagateTimeSkippingToNextRun(&persistencespb.WorkflowExecutionInfo{
 			TimeSkippingInfo: &persistencespb.TimeSkippingInfo{
-				Config:           &commonpb.TimeSkippingConfig{Enabled: true, MaxSkipPerSession: 50},
+				Config:           &commonpb.TimeSkippingConfig{Enabled: true, MaxSessionSkipCount: 50},
 				SessionSkipCount: 2,
 			},
 		})
 		s.Require().NotNil(tsc)
 		s.Require().NotNil(stateProp)
 		s.Nil(stateProp.GetInitialSkippedDuration())
 		s.Equal(int32(2), stateProp.GetInitialSkipCount())
-		s.Equal(int32(50), tsc.MaxSkipPerSession)
+		s.Equal(int32(50), tsc.MaxSessionSkipCount)
 	})
 
 	s.Run("FullPropagationOfAllTimeSippingStates", func() {
 		tsc, stateProp := propagateTimeSkippingToNextRun(&persistencespb.WorkflowExecutionInfo{
 			TimeSkippingInfo: &persistencespb.TimeSkippingInfo{
-				Config:                     &commonpb.TimeSkippingConfig{Enabled: true, MaxSkipPerSession: 50},
+				Config:                     &commonpb.TimeSkippingConfig{Enabled: true, MaxSessionSkipCount: 50},
 				AccumulatedSkippedDuration: durationpb.New(time.Hour),
 				SessionSkipCount:           3,
 			},
 		})
 		s.Require().NotNil(tsc)
-		s.Equal(int32(50), tsc.GetMaxSkipPerSession())
+		s.Equal(int32(50), tsc.GetMaxSessionSkipCount())
 		s.Require().NotNil(stateProp)
 		s.Equal(int32(3), stateProp.GetInitialSkipCount())
 	})
 
 	s.Run("SessionSkipCountPropagatesEvenWhenDisabled", func() {
 		tsc, stateProp := propagateTimeSkippingToNextRun(&persistencespb.WorkflowExecutionInfo{
 			TimeSkippingInfo: &persistencespb.TimeSkippingInfo{
-				Config:                     &commonpb.TimeSkippingConfig{Enabled: false, MaxSkipPerSession: 50},
+				Config:                     &commonpb.TimeSkippingConfig{Enabled: false, MaxSessionSkipCount: 50},
 				AccumulatedSkippedDuration: durationpb.New(time.Hour),
 				SessionSkipCount:           3,
 			},
@@ -215,9 +215,9 @@ func (s *mutableStateSuite) TestSnapshotTimeSkippingInfo_ForChildWorkflows() {
 		return &persistencespb.WorkflowExecutionInfo{
 			TimeSkippingInfo: &persistencespb.TimeSkippingInfo{
 				Config: &commonpb.TimeSkippingConfig{
-					Enabled:           true,
-					FastForward:       durationpb.New(3 * time.Hour),
-					MaxSkipPerSession: sessionMaxSkipCount,
+					Enabled:             true,
+					FastForward:         durationpb.New(3 * time.Hour),
+					MaxSessionSkipCount: sessionMaxSkipCount,
 				},
 				AccumulatedSkippedDuration: durationpb.New(accumSkip),
 				SessionSkipCount:           3,
@@ -245,7 +245,7 @@ func (s *mutableStateSuite) TestSnapshotTimeSkippingInfo_ForChildWorkflows() {
 		// has virtual time
 		s.Equal(accumSkip, propagatedState.GetInitialSkippedDuration().AsDuration())
 		// has config of max skip
-		s.Equal(sessionMaxSkipCount, tsc.GetMaxSkipPerSession())
+		s.Equal(sessionMaxSkipCount, tsc.GetMaxSessionSkipCount())
 		// no accumulated session skip
 		s.Equal(int32(0), propagatedState.GetInitialSkipCount())
 	})
@@ -463,7 +463,6 @@ func (s *mutableStateSuite) TestInitTimeSkippingInfo() {
 		s.Require().NotNil(tsi)
 		s.True(proto.Equal(cfg, tsi.GetConfig()))
 		s.Require().NotNil(tsi.GetFastForwardInfo())
-		s.Require().Equal(enumspb.TIME_SKIPPING_STOP_REASON_UNSPECIFIED, tsi.GetStopReason())
 		s.Require().Nil(tsi.GetAccumulatedSkippedDuration())
 		// timestamppb translates to UTC time
 		s.Require().Equal(baseTime.Add(3*time.Hour).UTC(),
@@ -517,7 +516,6 @@ func (s *mutableStateSuite) TestInitTimeSkippingInfo() {
 		s.Nil(tsi.GetConfig())
 		s.Equal(hasSkipped, tsi.GetAccumulatedSkippedDuration().AsDuration())
 		s.Equal(baseTime.Add(hasSkipped), s.mutableState.Now(), "inherited skip still shifts the virtual clock")
-		s.Equal(enumspb.TIME_SKIPPING_STOP_REASON_UNSPECIFIED, tsi.GetStopReason())
 	})
 
 	s.Run("SessionSkipCountSeededFromPropagation", func() {
@@ -596,7 +594,6 @@ func (s *mutableStateSuite) TestUpdateTimeSkippingInfo() {
 				Enabled: false,
 			},
 			AccumulatedSkippedDuration: durationpb.New(time.Hour),
-			StopReason:                 enumspb.TIME_SKIPPING_STOP_REASON_USER_DISABLED,
 		}
 		s.mutableState.executionInfo.TimeSkippingInfo = &currentTSI
 
@@ -611,7 +608,6 @@ func (s *mutableStateSuite) TestUpdateTimeSkippingInfo() {
 
 		s.Require().NotNil(newTSI)
 		s.True(proto.Equal(newConfig, newTSI.GetConfig()))
-		s.Equal(enumspb.TIME_SKIPPING_STOP_REASON_UNSPECIFIED, newTSI.GetStopReason(), "re-enabling clears the prior stop reason")
 		s.Require().NotNil(newTSI.GetFastForwardInfo())
 		// re-installing the fast-forward records the current versioned transition, so a task
 		// emitted here validates against a stable reference after a failover.
@@ -668,8 +664,6 @@ func (s *mutableStateSuite) TestUpdateTimeSkippingInfo() {
 		s.True(proto.Equal(tsc3, tsc3TSI.GetConfig()))
 		s.Nil(tsc3TSI.GetFastForwardInfo())
 		s.Equal(time.Hour, tsc3TSI.GetAccumulatedSkippedDuration().AsDuration())
-		s.Equal(enumspb.TIME_SKIPPING_STOP_REASON_USER_DISABLED, tsc3TSI.GetStopReason())
-
 	})
 
 	// Updating the config restarts the skip session: the per-session skip counter from the
@@ -678,13 +672,13 @@ func (s *mutableStateSuite) TestUpdateTimeSkippingInfo() {
 		s.mutableState.timeSource = clock.NewEventTimeSource()
 		s.mutableState.executionInfo.TimeSkippingInfo = &persistencespb.TimeSkippingInfo{
 			Config: &commonpb.TimeSkippingConfig{
-				Enabled:           false,
-				MaxSkipPerSession: 10,
+				Enabled:             false,
+				MaxSessionSkipCount: 10,
 			},
 			SessionSkipCount: 7,
 		}
 
-		s.mutableState.updateTimeSkippingInfo(&commonpb.TimeSkippingConfig{Enabled: true, MaxSkipPerSession: 10})
+		s.mutableState.updateTimeSkippingInfo(&commonpb.TimeSkippingConfig{Enabled: true, MaxSessionSkipCount: 10})
 
 		tsi := s.mutableState.executionInfo.GetTimeSkippingInfo()
 		s.Require().NotNil(tsi)
@@ -1417,16 +1411,15 @@ func (s *mutableStateSuite) TestApplyWorkflowExecutionTimeSkippingTransitionedEv
 		tsi := s.mutableState.GetExecutionInfo().TimeSkippingInfo
 		s.Require().False(tsi.GetConfig().GetEnabled())
 		s.Require().True(tsi.GetFastForwardInfo().GetHasReached())
-		s.Require().Equal(enumspb.TIME_SKIPPING_STOP_REASON_FAST_FORWARD_COMPLETED, tsi.GetStopReason())
 	})
 
 	// Every applied transition increments SessionSkipCount by one, and once the count reaches
 	// the per-session cap the config is disabled.
 	s.Run("SessionSkipCountIncrementsUntilCapDisables", func() {
 		s.mutableState.executionInfo.TimeSkippingInfo = &persistencespb.TimeSkippingInfo{
 			Config: &commonpb.TimeSkippingConfig{
-				Enabled:           true,
-				MaxSkipPerSession: 2,
+				Enabled:             true,
+				MaxSessionSkipCount: 2,
 			},
 		}
 		targetTime := baseTime.Add(time.Hour)
@@ -1440,7 +1433,6 @@ func (s *mutableStateSuite) TestApplyWorkflowExecutionTimeSkippingTransitionedEv
 		tsi := s.mutableState.GetExecutionInfo().TimeSkippingInfo
 		s.Require().Equal(int32(1), tsi.GetSessionSkipCount())
 		s.Require().True(tsi.GetConfig().GetEnabled())
-		s.Require().Equal(enumspb.TIME_SKIPPING_STOP_REASON_UNSPECIFIED, tsi.GetStopReason())
 
 		// second skip: count reaches the cap of 2, disables
 		err = s.mutableState.ApplyWorkflowExecutionTimeSkippingTransitionedEvent(
@@ -1450,7 +1442,6 @@ func (s *mutableStateSuite) TestApplyWorkflowExecutionTimeSkippingTransitionedEv
 		s.Require().NoError(err)
 		s.Require().Equal(int32(2), tsi.GetSessionSkipCount())
 		s.Require().False(tsi.GetConfig().GetEnabled())
-		s.Require().Equal(enumspb.TIME_SKIPPING_STOP_REASON_MAX_SKIP_PER_SESSION_REACHED, tsi.GetStopReason())
 	})
 
 	// A MaxSkipPerSession of 0 caps on the very first skip (1 >= 0), disabling immediately.
@@ -1471,7 +1462,6 @@ func (s *mutableStateSuite) TestApplyWorkflowExecutionTimeSkippingTransitionedEv
 		tsi := s.mutableState.GetExecutionInfo().TimeSkippingInfo
 		s.Require().Equal(int32(1), tsi.GetSessionSkipCount())
 		s.Require().False(tsi.GetConfig().GetEnabled())
-		s.Require().Equal(enumspb.TIME_SKIPPING_STOP_REASON_MAX_SKIP_PER_SESSION_REACHED, tsi.GetStopReason())
 	})
 }
 
@@ -1683,7 +1673,6 @@ func (s *mutableStateSuite) TestTimeSkippingInfoUtil() {
 		s.True(info.GetIsRunning())
 		s.Equal(now, info.GetCurrentTime().AsTime())
 		s.Nil(info.GetFastForwardInfo(), "no fast-forward set")
-		s.Equal(enumspb.TIME_SKIPPING_STOP_REASON_UNSPECIFIED, info.GetStopReason(), "no stop reason while running")
 	})
 
 	s.Run("ToDescribeInfoWithFastForward", func() {
@@ -1712,14 +1701,12 @@ func (s *mutableStateSuite) TestTimeSkippingInfoUtil() {
 		util := NewTimeSkippingInfoUtil(&persistencespb.TimeSkippingInfo{
 			Config:                     &commonpb.TimeSkippingConfig{Enabled: false},
 			AccumulatedSkippedDuration: durationpb.New(2 * time.Hour),
-			StopReason:                 enumspb.TIME_SKIPPING_STOP_REASON_USER_DISABLED,
 		})
 		msNow := time.Date(2027, 1, 1, 12, 0, 0, 0, time.UTC)
 		info := util.ToDescribeInfo(msNow)
 		s.NotNil(info)
 		s.False(info.GetIsRunning())
 		s.Equal(msNow, info.GetCurrentTime().AsTime())
-		s.Equal(enumspb.TIME_SKIPPING_STOP_REASON_USER_DISABLED, info.GetStopReason())
 	})
 
 }