fix(schedules): surface API errors on schedule mutations and preserve form edits (#4045)

* fix(schedules): surface API errors on schedule mutations and preserve form edits

Closes #4044

* fix(schedules): unify mutation error handling and strengthen regression
coverage

- Propagate create and edit failures to submitters consistently
- Extract shared error formatting with HTTP status and translated
  fallbacks
- Add translated context to create and edit error messages
- Cover HTTP, transport, parsing, and encoding failures
- Verify form preservation, successful retries, and modal error
  isolation

* Use 'message' in error instead of has

* Close confirmation modals on component cleanup

---------

Co-authored-by: Tegan Churchill <tegan.churchill@temporal.io>

Author: mmxmb

src/lib/components/schedule/schedule-action-modals/backfill-schedule-modal.svelte

@@ -74,7 +74,10 @@
   const invalidEndTime = $derived(endTimestamp <= startTimestamp);
 
   $effect(() => {
-    return () => clearConfirmationModalActionTimeout('backfill');
+    return () => {
+      clearConfirmationModalActionTimeout('backfill');
+      closeConfirmationModal('backfill');
+    };
   });
 </script>
 

src/lib/components/schedule/schedule-action-modals/delete-schedule-modal.svelte

@@ -21,7 +21,10 @@
   let { scheduleId, namespace }: Props = $props();
 
   $effect(() => {
-    return () => clearConfirmationModalActionTimeout('delete');
+    return () => {
+      clearConfirmationModalActionTimeout('delete');
+      closeConfirmationModal('delete');
+    };
   });
 </script>
 

src/lib/components/schedule/schedule-action-modals/pause-schedule-modal.svelte

@@ -25,7 +25,10 @@
   let reason = $state('');
 
   $effect(() => {
-    return () => clearConfirmationModalActionTimeout('pause');
+    return () => {
+      clearConfirmationModalActionTimeout('pause');
+      closeConfirmationModal('pause');
+    };
   });
 </script>
 

src/lib/components/schedule/schedule-action-modals/trigger-schedule-modal.svelte

@@ -33,7 +33,10 @@
   let selectedOverlapPolicy = writable<OverlapPolicy>(scheduleOverlapPolicy);
 
   $effect(() => {
-    return () => clearConfirmationModalActionTimeout('trigger');
+    return () => {
+      clearConfirmationModalActionTimeout('trigger');
+      closeConfirmationModal('trigger');
+    };
   });
 </script>
 

src/lib/components/schedule/schedule-form/form.svelte

@@ -13,6 +13,7 @@
   import { translate } from '$lib/i18n/translate';
   import { IconChevronLeft, IconTrash } from '$lib/io/icon';
   import {
+    confirmationModal,
     loading,
     openConfirmationModal,
     serverError,
@@ -77,6 +78,7 @@
     dataType: 'json',
     validators: zodClient(formScheduleSchema),
     resetForm: false,
+    invalidateAll: false,
     onUpdate: async ({ form }) => {
       if (!form.valid) return;
       await onSubmit(form.data);
@@ -172,6 +174,7 @@
         >
           <Button
             disabled={$submitting || !writeActionsAreAllowed()}
+            loading={$submitting}
             type="submit"
             class="max-sm:w-full"
             data-testid="create-schedule-button">{confirmText}</Button
@@ -202,7 +205,11 @@
       </div>
     </form>
 
-    <Alert intent="error" title={$serverError} hidden={!$serverError} />
+    <Alert
+      intent="error"
+      title={$serverError}
+      hidden={!$serverError || $confirmationModal !== 'none'}
+    />
     <CodecServerErrorBanner />
   {/if}
 </div>

src/lib/i18n/locales/en/schedules.ts

@@ -7,6 +7,8 @@ export const Strings = {
   'fix-form-errors': 'Please fix the following errors:',
   editing: 'Editing Schedule...',
   creating: 'Creating Schedule...',
+  'create-schedule-error': 'Error creating schedule: {{error}}',
+  'edit-schedule-error': 'Error editing schedule: {{error}}',
   'back-to-schedule': 'Back to Schedule',
   'back-to-schedules': 'Back to Schedules',
   id: 'Schedule ID',