fix: fixed bug in prefer-focus with call expression in expect statement

Author: Ben Monro

lib/rules/prefer-focus.js

@@ -39,11 +39,21 @@ module.exports = {
           node: node.parent,
           message: `Use toHaveFocus instead of checking activeElement`,
           fix(fixer) {
-            return [
-              fixer.replaceText(node, element.name),
-              fixer.remove(element),
-              fixer.replaceText(matcher, 'toHaveFocus'),
-            ];
+            if (element.name) {
+              return [
+                fixer.replaceText(node, element.name),
+                fixer.remove(element),
+                fixer.replaceText(matcher, 'toHaveFocus'),
+              ];
+            } else {
+              return [
+                fixer.removeRange([node.start, element.start]),
+                fixer.insertTextAfterRange(
+                  [element.end, element.end + 1],
+                  '.not.toHaveFocus()'
+                ),
+              ];
+            }
           },
         });
       },
@@ -77,6 +87,15 @@ module.exports = {
           node: node.parent,
           message: `Use toHaveFocus instead of checking activeElement`,
           fix(fixer) {
+            if (!element.name) {
+              return [
+                fixer.removeRange([node.start, element.start]),
+                fixer.insertTextAfterRange(
+                  [element.end, element.end + 1],
+                  '.toHaveFocus()'
+                ),
+              ];
+            }
             return [
               fixer.replaceText(node, element.name),
               fixer.remove(element),

tests/lib/rules/prefer-focus.js

@@ -24,6 +24,24 @@ ruleTester.run('prefer-focus', rule, {
       ],
       output: 'expect(foo).toHaveFocus()',
     },
+    {
+      code: `expect(document.activeElement).toBe(getByText('Foo'))`,
+      errors: [
+        {
+          message: 'Use toHaveFocus instead of checking activeElement',
+        },
+      ],
+      output: `expect(getByText('Foo')).toHaveFocus()`,
+    },
+    {
+      code: `expect(document.activeElement).not.toBe(getByText('Foo'))`,
+      errors: [
+        {
+          message: 'Use toHaveFocus instead of checking activeElement',
+        },
+      ],
+      output: `expect(getByText('Foo')).not.toHaveFocus()`,
+    },
     {
       code: 'expect(document.activeElement).not.toBe(foo)',
       errors: [