Skip to content

Commit 4808bca

Browse files
gndeliaBelco90
andauthored
fix(prefer-user-event): prevent crash with custom createEvent function (#422) (#422)
Closes #405 Co-authored-by: Mario Beltrán Alarcón <[email protected]>
1 parent 5dff88e commit 4808bca

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

lib/rules/prefer-user-event.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ export default createTestingLibraryRule<Options, MessageIds>({
182182
ASTUtils.isIdentifier(node.init.callee.property)
183183
) {
184184
fireEventMethodName = node.init.callee.property.name;
185-
} else {
185+
} else if (node.init.arguments.length > 0) {
186186
fireEventMethodName = (node.init.arguments[0] as TSESTree.Literal)
187187
.value as string;
188188
}

tests/lib/rules/prefer-user-event.test.ts

+6
Original file line numberDiff line numberDiff line change
@@ -265,6 +265,12 @@ ruleTester.run(RULE_NAME, rule, {
265265
fireEventAliased(node, event)
266266
`,
267267
},
268+
{
269+
code: `
270+
const createEvent = () => 'Event';
271+
const event = createEvent();
272+
`,
273+
},
268274
],
269275
invalid: [
270276
...createScenarioWithImport<TSESLint.InvalidTestCase<MessageIds, Options>>(

0 commit comments

Comments
 (0)