Migrate lemon's remaining ggplot features to ggh4x

[stefanedwards]

Hi,

I am slowly retiring my R-package lemon, as I do not have time to maintain it. You have already reimplemented many of my ggplot2 features into ggh4x, such as the facet features and geom_line. Could we discuss migrating more functions from lemon to ggh4x?

• geom_siderange, similar to your geom_rectmargin, but more akin to geom_rug.
• annotate_y_axis and annotate_x_axis that enables users to put annotations in the margin, with exact positions and labeling.
• scale_x_symmetric and scale_y_symmetric that ensures an axis is centered at a specific value, e.g. 0 or 0.5.
• coord_flex_cart which introduces more flexible options for drawing axes, e.g., using brackets instead of ticks, or limiting axis lines to fit to data.
• reposition_legend, grid_arrange_shared_legend, g_legend for placing legends.

[teunbrand]

Hi Stefan,

I'm sorry to hear about lemon's upcoming retirement. We can certainly discuss migrating functions, but I'm not making any hard promises right now with regards to 'if' and 'in what shape' functionality would be adopted into ggh4x (or elsewhere).

• geom_siderange() this seems like a reasonable thing to migrate.
• annotate_x/y_axis() seems to me like they might fit better as a guide extension, which I've been shovelling over to {legendry}.
• scale_x/y_symmetric() seems like it could be replaced by a helper function for the limits, maybe? See proposal in Feature request: limit functions r-lib/scales#490.
• coord_flex_cart() also seems like this might better be replaced by ggplot2::coord_cartesian() + guide extensions.
• Some of the legend stuff seem like gtable editing after it has been constructed, which I'd like to steer clear of. I think some stuff like cowplot::get_legend() and patchwork::plot_layout(guides = "collect") already capture some of that functionality.

I'm not sure how many reverse dependencies lemon has, but if it is a managable amount it may also be possible to appeal to those maintainers to divest away from lemon.

[teunbrand]

Alternatively, you have looked around if anybody else might be interested ini maintaining lemon instead?

[stefanedwards]

Alternatively, you have looked around if anybody else might be interested ini maintaining lemon instead?

I'm not in contact with anybody, but your breakdown of the different features seems like a good place to start looking. lemon has long been a mixed bucket of features, so it makes sense to break it apart cf. your suggestions.

There are 4 strong dependencies on lemon, so it should be fairly easy to redirect them into other packages.

[teunbrand]

For scale_x/y_symmetric() there is also https://davidhodge931.github.io/ggblanket/reference/scale_x_symmetric.html.

[davidhodge931]

I've got a bunch of functions that I plan on releasing before the end of the year to annotate axis lines, axis ticks and axis text amongst a few other things, FYI.

Still trying to work out if I make it a seperate package or not. But I'll release it in some shape or form before the end of the year.

Think the lemon implication of scale_x/y_symmetric is covered off nicely by those scales functions in the works. My functions are doing something different (bad naming be me, didn't know about these lemon functions)