Skip to content

Commit 57139fb

Browse files
committed
Fix whatwg#245 - Addressing new popover values
Since the popover attribute got a new value, it's "find topmost popover ancestor" algorithm changed, and this PR attempts to address this in the Fullscreen API specification. After discussing with Luke Warlow we came to the conclusion that this is probably the intended change for the Fullscreen API spec.
1 parent 1c324ee commit 57139fb

File tree

1 file changed

+14
-3
lines changed

1 file changed

+14
-3
lines changed

fullscreen.bs

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,11 @@ Markup Shorthands: css no
1111
</pre>
1212

1313
<pre class=link-defaults>
14+
spec:html
15+
type:dfn; text:allowed to use
16+
type:dfn; text:showing hint popover list
17+
type:dfn; text:showing auto popover list
18+
1419
spec:dom
1520
type:dfn; for:/; text:document
1621
type:dfn; for:/; text:element
@@ -69,11 +74,16 @@ is an <a>ordered set</a> of (<a>string</a>, <a>element</a>) <a>tuples</a>. It is
6974
<p>To <dfn>fullscreen an <var>element</var></dfn>:
7075

7176
<ol>
77+
<li><p>Let <var>document</var> be <var>element</var>'s <a>node document</a>.
78+
7279
<li><p>Let <var>hideUntil</var> be the result of running <a>topmost popover ancestor</a> given
73-
<var>element</var>, null, and false.
80+
<var>element</var>, <var>document</var>'s <a>showing hint popover list</a>, null, and false.
81+
82+
<li><p>If <var>hideUntil</var> is null, then set <var>hideUntil</var> to the result of running
83+
topmost popover ancestor, given <var>element</var>, <var>document</var>'s <a>showing auto popover
84+
list</a>, null, and false.
7485

75-
<li><p>If <var>hideUntil</var> is null, then set <var>hideUntil</var> to <var>element</var>'s
76-
<span>node document</span>.
86+
<li><p>If <var>hideUntil</var> is null, then set <var>hideUntil</var> to <var>document</var>.
7787

7888
<li><p>Run <a>hide all popovers until</a> given <var>hideUntil</var>, false, and true.
7989

@@ -725,6 +735,7 @@ Rafał Chłodnicki,
725735
Riff Jiang,
726736
Rune Lillesveen,
727737
Sigbjørn Vik,
738+
Simon Farre,
728739
Simon Pieters,
729740
Tab Atkins-Bittner,
730741
Takayoshi Kochi,

0 commit comments

Comments
 (0)