docs(docs-infra): clean up code and use inferred types where possible (angular#64139)

MeAkib · kirjs · commit 9a913dcfa9b4 · 2025-09-29T16:48:11.000-04:00
PR Close angular#64139
diff --git a/adev/shared-docs/components/cookie-popup/cookie-popup.component.ts b/adev/shared-docs/components/cookie-popup/cookie-popup.component.ts
@@ -27,7 +27,7 @@ export class CookiePopup {
   private readonly localStorage = inject(LOCAL_STORAGE);
 
   /** Whether the user has accepted the cookie disclaimer. */
-  readonly hasAccepted = signal<boolean>(false);
+  readonly hasAccepted = signal(false);
 
   constructor() {
     // Needs to be in a try/catch, because some browsers will
diff --git a/adev/shared-docs/components/navigation-list/navigation-list.component.ts b/adev/shared-docs/components/navigation-list/navigation-list.component.ts
@@ -14,8 +14,7 @@ import {IconComponent} from '../icon/icon.component';
 import {IsActiveNavigationItem} from '../../pipes';
 import {NgTemplateOutlet, TitleCasePipe} from '@angular/common';
 import {MatTooltipModule} from '@angular/material/tooltip';
-import {SlideToggle} from '../slide-toggle/slide-toggle.component';
-import {FormControl, ReactiveFormsModule} from '@angular/forms';
+import {ReactiveFormsModule} from '@angular/forms';
 
 @Component({
   selector: 'docs-navigation-list',
@@ -35,10 +34,10 @@ import {FormControl, ReactiveFormsModule} from '@angular/forms';
 })
 export class NavigationList {
   readonly navigationItems = input.required<NavigationItem[]>();
-  readonly displayItemsToLevel = input<number>(2);
+  readonly displayItemsToLevel = input(2);
   readonly collapsableLevel = input<number | undefined>();
-  readonly expandableLevel = input<number>(2);
-  readonly isDropdownView = input<boolean>(false);
+  readonly expandableLevel = input(2);
+  readonly isDropdownView = input(false);
 
   readonly linkClicked = output<void>();
 
diff --git a/adev/shared-docs/components/select/select.component.ts b/adev/shared-docs/components/select/select.component.ts
@@ -37,7 +37,7 @@ export class Select implements ControlValueAccessor {
   readonly id = input.required<string>({alias: 'selectId'});
   readonly name = input.required<string>();
   readonly options = input.required<SelectOption[]>();
-  readonly disabled = model<boolean>(false);
+  readonly disabled = model(false);
 
   // Implemented as part of ControlValueAccessor.
   private onChange: (value: SelectOptionValue) => void = (_: SelectOptionValue) => {};
diff --git a/adev/shared-docs/components/slide-toggle/slide-toggle.component.ts b/adev/shared-docs/components/slide-toggle/slide-toggle.component.ts
@@ -11,7 +11,6 @@ import {ControlValueAccessor, NG_VALUE_ACCESSOR} from '@angular/forms';
 
 @Component({
   selector: 'docs-slide-toggle',
-  imports: [],
   changeDetection: ChangeDetectionStrategy.OnPush,
   templateUrl: './slide-toggle.component.html',
   styleUrls: ['./slide-toggle.component.scss'],
@@ -26,7 +25,7 @@ import {ControlValueAccessor, NG_VALUE_ACCESSOR} from '@angular/forms';
 export class SlideToggle implements ControlValueAccessor {
   readonly buttonId = input.required<string>();
   readonly label = input.required<string>();
-  readonly disabled = model<boolean>(false);
+  readonly disabled = model(false);
 
   // Implemented as part of ControlValueAccessor.
   private onChange: (value: boolean) => void = (_: boolean) => {};
diff --git a/adev/src/app/app-scroller.ts b/adev/src/app/app-scroller.ts
@@ -62,7 +62,7 @@ export class AppScroller {
         this.scroll();
       });
 
-    // This value is primarly intended to offset the scroll position on mobile when the menu is on the top.
+    // This value is primarily intended to offset the scroll position on mobile when the menu is on the top.
     // But on desktop, it doesn't hurt to have a small offset either.
     this.viewportScroller.setOffset([0, 64]);
   }
diff --git a/adev/src/app/core/services/theme-manager.service.ts b/adev/src/app/core/services/theme-manager.service.ts
@@ -9,7 +9,6 @@
 import {DOCUMENT, isPlatformBrowser} from '@angular/common';
 import {Injectable, PLATFORM_ID, inject, signal} from '@angular/core';
 import {LOCAL_STORAGE} from '@angular/docs';
-import {Subject} from 'rxjs';
 
 // Keep these constants in sync with the code in index.html
 
@@ -29,8 +28,6 @@ export class ThemeManager {
   private readonly platformId = inject(PLATFORM_ID);
 
   readonly theme = signal<Theme | null>(this.getThemeFromLocalStorageValue());
-  // Zoneless - it's required to notify that theme was changed. It could be removed when signal-based components will be available.
-  readonly themeChanged$ = new Subject<void>();
 
   constructor() {
     if (!isPlatformBrowser(this.platformId)) {
@@ -67,7 +64,6 @@ export class ThemeManager {
       documentClassList.add(LIGHT_MODE_CLASS_NAME);
       documentClassList.remove(DARK_MODE_CLASS_NAME);
     }
-    this.themeChanged$.next();
   }
 
   private getThemeFromLocalStorageValue(): Theme | null {
diff --git a/adev/src/app/main.component.ts b/adev/src/app/main.component.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-import {Component, effect, inject, model, WritableSignal} from '@angular/core';
+import {Component, effect, inject, model} from '@angular/core';
 import {IS_SEARCH_DIALOG_OPEN, Search} from '@angular/docs';
 import {RouterOutlet} from '@angular/router';
 
@@ -16,7 +16,7 @@ import {RouterOutlet} from '@angular/router';
   template: `<router-outlet />`,
 })
 export default class MainComponent {
-  private readonly displaySearchDialog: WritableSignal<boolean> = inject(IS_SEARCH_DIALOG_OPEN);
+  private readonly displaySearchDialog = inject(IS_SEARCH_DIALOG_OPEN);
   private readonly searchService = inject(Search);
   readonly search = model<string | undefined>('');
 

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ export class AppScroller {`
`62`	`62`	`this.scroll();`
`63`	`63`	`});`
`64`	`64`
`65`		`- // This value is primarly intended to offset the scroll position on mobile when the menu is on the top.`
	`65`	`+ // This value is primarily intended to offset the scroll position on mobile when the menu is on the top.`
`66`	`66`	`// But on desktop, it doesn't hurt to have a small offset either.`
`67`	`67`	`this.viewportScroller.setOffset([0, 64]);`
`68`	`68`	`}`