SAT-47603 - Add missing ouiaId labels to components (#1238)

Author: lfu

.eslintrc

@@ -1,10 +1,11 @@
 {
-  "plugins": ["@theforeman/foreman", "spellcheck"],
+  "plugins": ["@theforeman/foreman", "@theforeman/rules", "spellcheck"],
   "extends": [
     "plugin:@theforeman/foreman/core",
     "plugin:@theforeman/foreman/plugins"
   ],
   "rules": {
+    "@theforeman/rules/require-ouiaid": "error",
     "spellcheck/spell-checker": [
       "error",
       {

webpack/ForemanInventoryUpload/Components/InventorySettings/MinimalInventoryDropdown.js

@@ -79,6 +79,7 @@ const MinimalInventoryDropdown = ({ setChosenValue }) => {
           isFullWidth
           onClick={onToggleClick}
           isExpanded={isOpen}
+          ouiaId="inventory-dropdown-toggle"
         >
           {dropdownValues[currentDropdownValue].title}
         </MenuToggle>

webpack/ForemanInventoryUpload/Components/PageHeader/PageTitle.js

@@ -59,6 +59,7 @@ const PageTitle = () => {
               variant="plain"
               onClick={() => setIsDropdownOpen(prev => !prev)}
               isExpanded={isDropdownOpen}
+              ouiaId="title-dropdown-toggle"
             >
               <EllipsisVIcon />
             </MenuToggle>

webpack/InsightsCloudSync/Components/InsightsTable/InsightsTableConstants.js

@@ -31,7 +31,7 @@ export const actionsFormatter = rowData => {
   recommendationUrl &&
     !isLocalAdvisorEngine &&
     dropdownItems.push(
-      <DropdownItem key="recommendation-url">
+      <DropdownItem key="recommendation-url" ouiaId="insights-dropdown-item-recommendation-url">
         <a href={recommendationUrl} target="_blank" rel="noopener noreferrer">
           {__('View in Red Hat Insights')} <ExternalLinkAltIcon />
         </a>
@@ -40,7 +40,7 @@ export const actionsFormatter = rowData => {
 
   accessRHUrl &&
     dropdownItems.push(
-      <DropdownItem key="access-url">
+      <DropdownItem key="access-url" ouiaId="insights-dropdown-item-knowledgebase">
         <a href={accessRHUrl} target="_blank" rel="noopener noreferrer">
           {__('Knowledgebase article')} <ExternalLinkAltIcon />
         </a>

webpack/InsightsCloudSync/Components/InsightsTable/Pagination.js

@@ -42,6 +42,7 @@ const Pagination = ({ variant, ...props }) => {
 
   return (
     <PfPagination
+      ouiaId={`recommendations-pagination-${variant}`}
       itemCount={itemCount}
       widgetId={`recommendation-pagination-${variant}`}
       perPage={perPage}

webpack/InsightsCloudSync/Components/ToolbarDropdown.js

@@ -53,6 +53,7 @@ const ToolbarDropdown = ({ onRecommendationSync }) => {
           aria-label={__('Recommendations actions')}
           onClick={() => setIsDropdownOpen(prev => !prev)}
           isExpanded={isDropdownOpen}
+          ouiaId="recommendations-dropdown-toggle"
         >
           <EllipsisVIcon />
         </MenuToggle>

webpack/common/DropdownToggle.js

@@ -18,6 +18,7 @@ const DropdownToggle = ({ items, ...props }) => {
           aria-label={__('Table actions')}
           onClick={() => setOpen(prev => !prev)}
           isExpanded={isOpen}
+          ouiaId="toggle-dropdown-toggle"
         >
           <EllipsisVIcon />
         </MenuToggle>