You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
That is it should check whether the previousValue is not undefined. If it is, then el.removeClass(undefined) will remove all the classes previously defined for some other purposes. Imagine I have an icon defined as <i class="fa fa-envelope"/>. If previousValue=undefined, then it will remove fa fa-envelope classes completely so the element will end up being <i class=""/>.
The text was updated successfully, but these errors were encountered:
I think I had observed that behavior somewhere in the 1.8.x series. Maybe they've changed it again...? I guess I don't know if this issue is still valid.
Basically this line https://github.com/theironcook/Backbone.ModelBinder/blob/master/Backbone.ModelBinder.js#L400 is not completely correct:
It should be:
That is it should check whether the
previousValue
is not undefined. If it is, thenel.removeClass(undefined)
will remove all the classes previously defined for some other purposes. Imagine I have an icon defined as<i class="fa fa-envelope"/>
. IfpreviousValue=undefined
, then it will removefa fa-envelope
classes completely so the element will end up being<i class=""/>
.The text was updated successfully, but these errors were encountered: