Skip to content

Allow set random seed for reproducibility in CompositionalAnalysis objects#49

Open
yihming wants to merge 2 commits intotheislab:masterfrom
lilab-bcb:master
Open

Allow set random seed for reproducibility in CompositionalAnalysis objects#49
yihming wants to merge 2 commits intotheislab:masterfrom
lilab-bcb:master

Conversation

@yihming
Copy link
Copy Markdown

@yihming yihming commented Mar 3, 2022

Usage

In sccoda.util.comp_ana.CompositionalAnalysis, add seed optional parameter:

  • If not specifying a value, it behaves as normal.
  • If specifying a value as the following:
from sccoda.util import comp_ana as mod
...
model_salm = mod.CompositionalAnalysis(data_salm, formula="Condition", reference_cell_type="Goblet", seed=0) 

This code reproduces the same result in different execution times.

@johannesostner
Copy link
Copy Markdown
Collaborator

Hi, thanks for this pull request!
I am unsure though, whether this change is necessary. As far as I know, it is also possible to get consistent results by running

tf.random.set_seed(0)
model_salm = mod.CompositionalAnalysis(data_salm, formula="Condition", reference_cell_type="Goblet")

Are you aware of any situations where this strategy could fail to produce reproducible results?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants