Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 deprecation: League\Pipeline\Pipeline::__construct(): Implicitly marking parameter $processor as nullable is deprecated, the explicit nullable type must be used instead in Pipeline.php #61

Closed
jhm-ciberman opened this issue Jan 20, 2025 · 4 comments

Comments

@jhm-ciberman
Copy link

PHP 8.4 added a new deprecation:

ErrorException: League\Pipeline\Pipeline::__construct(): Implicitly marking parameter $processor as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/vendor/league/pipeline/src/Pipeline.php:18

This package is internally used by https://github.com/hisorange/browser-detect so fixing this should be important. It's a single character fix.

@andus4n
Copy link

andus4n commented Feb 2, 2025

i second this. we need this small update.
otherwise, our only solution is cweagans/composer-patches

@frankdejonge @shadowhand

@onlime
Copy link

onlime commented Feb 5, 2025

There's some progress on hisorange/browser-detect#229 - so if you are using hisorange/browser-detect, you soon no longer need to care about this package. My PR won't be needed either, as @pataar has already refactored the pipeline away completely in hisorange/browser-detect#230

But I am still waiting for a replacement of this unmaintained (??) package in Bag.

@frankdejonge
Copy link
Member

This is fixed now in 1.1.0

@onlime
Copy link

onlime commented Feb 6, 2025

This is fixed now in 1.1.0

wow, this is super welcoming, as I am just planning to refactor a huge project from Spatie's Laravel-Data (which performs very bad) to Bag, and the only thing that held me back was your package. Glad to see a new release here! Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants