Add a derive(PartialEq, Eq) to DisplayError #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creeper6530
added a commit
to creeper6530/maturitni-projekt
that referenced
this pull request
Nov 24, 2025
TODO: Watch therealprof/display-interface#55 and include the DisplayError in the variant once it starts to implement Eq and PartialEq
Author
|
Just thought that implementing |
almindor
approved these changes
Nov 24, 2025
Collaborator
almindor
left a comment
almindor
left a comment
There was a problem hiding this comment.
LGTM, I'll let @therealprof merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my own project I'm making an enum that contains various error types, and one of those is a display error from the
ssd1306crate, but when I tried deriving PartialEq and Eq on my enum, I found myself unable to because it contained your enumDisplayErroras a parameter, and that doesn't implement it.So, I'm doing this to help myself, really.
Feel free to bump up the release number before merge, but I would love if this got merged soon so that I can nag
ssd1306's maintainer to update next.