Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Having LayerMasker.Layers Take a StartingLayer Field #125

Open
Chris3606 opened this issue Mar 26, 2023 · 0 comments
Open

Consider Having LayerMasker.Layers Take a StartingLayer Field #125

Chris3606 opened this issue Mar 26, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@Chris3606
Copy link
Contributor

Currently, the LayerMasker only takes a number of layers, not a starting layer. This means that, if you pass uint.MaxValue to LayerMasker.Layers(), it will return layers below a minimum layer, if you are using one.

LayeredSpatialMap gets around this by using a couple layer maskers and also doing bit-shifts on values incoming. However, a simple mask >> startingLayer << startingLayer would remove them entirely from the mask.

In order to gain more intuitive behavior, it may be useful to have LayerMasker implement support for a starting (minimum) layer specifically.

@Chris3606 Chris3606 added the enhancement New feature or request label Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant