Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type of node-sass package #61

Open
the-homeless-god opened this issue Dec 6, 2020 · 4 comments
Open

Type of node-sass package #61

the-homeless-god opened this issue Dec 6, 2020 · 4 comments

Comments

@the-homeless-god
Copy link

Currently, node-sass has been marked as 'optional" dependency in package.json, but there are a few issues:

  • rollup-plugin-scss can't work without node-sass
  • project can't use installation like npm install --no-optional because rollup-plugin-scss will throws issues about missing of node-sass

Also some packages were deprecated

image

@thgh
Copy link
Owner

thgh commented Dec 7, 2020

  1. It can, using the sass package which does not require binaries
  2. Woops, the readme should be updated to indicate that node-sass should be installed specifically.

@sirikon
Copy link

sirikon commented Dec 23, 2020

I would suggest to not include node-sass as an optional dependency and always require to specify the preferred sass package in package.json.

Currently want to use the plugin with sass (dart-sass) but node-sass gets installed anyway.

@thgh
Copy link
Owner

thgh commented Jan 5, 2021

Let's do that for v3, PR welcome!

@FlorianWendelborn
Copy link

Thanks for fixing this. This simple change sped-up our install time in a medium-size monorepo by 70%: 3YOURMIND/kotti#403

@FlorianWendelborn FlorianWendelborn mentioned this issue Apr 15, 2021
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants