Initialize extensions in onInstall (#114)

* Initialize extensions in onInstall

* Remove caller/sender args since delegateCall is used everywhere

* Initialize primary sale recipient as msg.sender without decoding data

Author: nkrishang

src/ModularCore.sol

@@ -36,10 +36,10 @@ abstract contract ModularCore is IModularCore, OwnableRoles {
     //////////////////////////////////////////////////////////////*/
 
     /// @notice Emitted when an extension is installed.
-    event ExtensionInstalled(address sender, address implementation, address installedExtension);
+    event ExtensionInstalled(address caller, address implementation, address installedExtension);
 
     /// @notice Emitted when an extension is uninstalled.
-    event ExtensionUninstalled(address sender, address implementation, address installedExtension);
+    event ExtensionUninstalled(address caller, address implementation, address installedExtension);
 
     /*//////////////////////////////////////////////////////////////
                                 STORAGE
@@ -233,7 +233,7 @@ abstract contract ModularCore is IModularCore, OwnableRoles {
         // Call `onInstall` callback function if extension has registered installation callback.
         if (config.registerInstallationCallback) {
             (bool success, bytes memory returndata) =
-                _extension.call{value: msg.value}(abi.encodeCall(IInstallationCallback.onInstall, (msg.sender, _data)));
+                _extension.delegatecall(abi.encodeCall(IInstallationCallback.onInstall, (_data)));
             if (!success) {
                 _revert(returndata, CallbackExecutionReverted.selector);
             }
@@ -271,9 +271,8 @@ abstract contract ModularCore is IModularCore, OwnableRoles {
         }
 
         if (config.registerInstallationCallback) {
-            (bool success, bytes memory returndata) = _extension.call{value: msg.value}(
-                abi.encodeCall(IInstallationCallback.onUninstall, (msg.sender, _data))
-            );
+            (bool success, bytes memory returndata) =
+                _extension.delegatecall(abi.encodeCall(IInstallationCallback.onUninstall, (_data)));
             if (!success) {
                 _revert(returndata, CallbackExecutionReverted.selector);
             }

src/callback/BeforeApproveCallbackERC20.sol

@@ -14,13 +14,13 @@ contract BeforeApproveCallbackERC20 {
 
     /**
      *  @notice The beforeApproveERC20 hook that is called by a core token before approving tokens.
-     *  @param _caller The address of the caller.
+     *
      *  @param _from The address that is approving tokens.
      *  @param _to The address that is being approved.
      *  @param _amount The amount of tokens being approved.
      *  @return result Abi encoded bytes result of the hook.
      */
-    function beforeApproveERC20(address _caller, address _from, address _to, uint256 _amount)
+    function beforeApproveERC20(address _from, address _to, uint256 _amount)
         external
         virtual
         returns (bytes memory result)

src/callback/BeforeApproveCallbackERC721.sol

@@ -14,14 +14,14 @@ contract BeforeApproveCallbackERC721 {
 
     /**
      *  @notice The beforeApproveERC721 hook that is called by a core token before approving a token.
-     *  @param _caller The address of the caller.
+     *
      *  @param _from The address that is approving tokens.
      *  @param _to The address that is being approved.
      *  @param _tokenId The token ID being approved.
      *  @param _approve The approval status to set.
      *  @return result Abi encoded bytes result of the hook.
      */
-    function beforeApproveERC721(address _caller, address _from, address _to, uint256 _tokenId, bool _approve)
+    function beforeApproveERC721(address _from, address _to, uint256 _tokenId, bool _approve)
         external
         virtual
         returns (bytes memory result)

src/callback/BeforeApproveForAllCallback.sol

@@ -14,12 +14,12 @@ contract BeforeApproveForAllCallback {
 
     /**
      *  @notice The beforeApproveForAll hook that is called by a core token before approving an operator to transfer all tokens.
-     *  @param _caller The address of the caller.
+     *
      *  @param _from The address that is approving tokens.
      *  @param _to The address that is being approved.
      *  @param _approved Whether to grant or revoke approval.
      */
-    function beforeApproveForAll(address _caller, address _from, address _to, bool _approved)
+    function beforeApproveForAll(address _from, address _to, bool _approved)
         external
         virtual
         returns (bytes memory result)

src/callback/BeforeBatchTransferCallbackERC1155.sol

@@ -14,20 +14,18 @@ contract BeforeBatchTransferCallbackERC1155 {
 
     /**
      *  @notice The beforeBatchTransferERC1155 hook that is called by a core token before batch transferring tokens.
-     *  @param _caller The address of the caller.
+     *
      *  @param from The address that is transferring tokens.
      *  @param to The address that is receiving tokens.
      *  @param ids The token IDs being transferred.
      *  @param values The quantities of tokens being transferred.
      *  @return result Abi encoded bytes result of the hook.
      */
-    function beforeBatchTransferERC1155(
-        address _caller,
-        address from,
-        address to,
-        uint256[] calldata ids,
-        uint256[] calldata values
-    ) external virtual returns (bytes memory result) {
+    function beforeBatchTransferERC1155(address from, address to, uint256[] calldata ids, uint256[] calldata values)
+        external
+        virtual
+        returns (bytes memory result)
+    {
         revert BeforeBatchTransferCallbackERC1155NotImplemented();
     }
 }

src/callback/BeforeBurnCallbackERC1155.sol

@@ -14,14 +14,14 @@ contract BeforeBurnCallbackERC1155 {
 
     /**
      *  @notice The beforeBurnERC1155 hook that is called by a core token before burning a token.
-     *  @param _caller The address of the caller.
+     *
      *  @param _from The address whose tokens are being burned.
      *  @param _id The token ID being burned.
      *  @param _value The quantity of tokens being burned.
      *  @param _data The encoded arguments for the beforeBurn hook.
      *  @return result Abi encoded bytes result of the hook.
      */
-    function beforeBurnERC1155(address _caller, address _from, uint256 _id, uint256 _value, bytes memory _data)
+    function beforeBurnERC1155(address _from, uint256 _id, uint256 _value, bytes memory _data)
         external
         payable
         virtual

src/callback/BeforeBurnCallbackERC20.sol

@@ -14,13 +14,13 @@ contract BeforeBurnCallbackERC20 {
 
     /**
      *  @notice The beforeBurnERC20 hook that is called by a core token before burning tokens.
-     *  @param _caller The address of the caller.
+     *
      *  @param _from The address whose tokens are being burned.
      *  @param _amount The amount of tokens being burned.
      *  @param _data The encoded arguments for the beforeBurn hook.
      *  @return result Abi encoded bytes result of the hook.
      */
-    function beforeBurnERC20(address _caller, address _from, uint256 _amount, bytes memory _data)
+    function beforeBurnERC20(address _from, uint256 _amount, bytes memory _data)
         external
         payable
         virtual

src/callback/BeforeBurnCallbackERC721.sol

@@ -14,12 +14,12 @@ contract BeforeBurnCallbackERC721 {
 
     /**
      *  @notice The beforeBurnERC721 hook that is called by a core token before burning a token.
-     *  @param _caller The address of the caller.
+     *
      *  @param _tokenId The token ID being burned.
      *  @param _data The encoded arguments for the beforeBurn hook.
      *  @return result Abi encoded bytes result of the hook.
      */
-    function beforeBurnERC721(address _caller, uint256 _tokenId, bytes memory _data)
+    function beforeBurnERC721(uint256 _tokenId, bytes memory _data)
         external
         payable
         virtual

src/callback/BeforeMintCallbackERC1155.sol

@@ -14,14 +14,14 @@ contract BeforeMintCallbackERC1155 {
 
     /**
      *  @notice The beforeMintERC1155 hook that is called by a core token before minting tokens.
-     *  @param _caller The address of the caller.
+     *
      *  @param _to The address that is minting tokens.
      *  @param _id The token ID being minted.
      *  @param _quantity The quantity of tokens to mint.
      *  @param _data Optional extra data passed to the hook.
      *  @return result Abi encoded bytes result of the hook.
      */
-    function beforeMintERC1155(address _caller, address _to, uint256 _id, uint256 _quantity, bytes memory _data)
+    function beforeMintERC1155(address _to, uint256 _id, uint256 _quantity, bytes memory _data)
         external
         payable
         virtual

src/callback/BeforeMintCallbackERC20.sol

@@ -14,13 +14,13 @@ contract BeforeMintCallbackERC20 {
 
     /**
      *  @notice The beforeMintERC20 hook that is called by a core token before minting tokens.
-     *  @param _caller The address of the caller.
+     *
      *  @param _to The address to mint tokens to.
      *  @param _amount The amount of tokens to mint.
      *  @param _data Optional extra data passed to the hook.
      *  @return result Abi encoded bytes result of the hook.
      */
-    function beforeMintERC20(address _caller, address _to, uint256 _amount, bytes memory _data)
+    function beforeMintERC20(address _to, uint256 _amount, bytes memory _data)
         external
         payable
         virtual