Skip to content

Reduce duplication in assert_* macro bodies #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thomcc opened this issue May 23, 2018 · 0 comments
Closed

Reduce duplication in assert_* macro bodies #2

thomcc opened this issue May 23, 2018 · 0 comments

Comments

@thomcc
Copy link
Owner

thomcc commented May 23, 2018

The bodies of assert_{lt,gt,le,ge} and are big-ish and almost identical.

I don't see a way around this until rust-lang/rust#35853 is fixed, and even then it seems painful to keep good docs.

A previous commit used a helper macro but it resulted in worse documentation and required exporting that helper to users.

@thomcc thomcc closed this as completed Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant