From ba459bcaa1f2389f446400d5f1a60c7e576d7734 Mon Sep 17 00:00:00 2001 From: Mike Beaton Date: Sat, 26 Oct 2024 20:49:30 +0100 Subject: [PATCH] Features/Intel|Platforms/Intel: Complete pending changes to [Components.{ARCH}] As noted in the code, it was intended to update various manually specified instances of [Components.IA32/X64] to [Components.$(DXE_ARCH)] or [Components.$(PEI_ARCH)] as appropriate, once macro expansion in the Components {ARCH} value was supported. This support was added some time ago[1], but the marked changes were never made. [1]: https://bugzilla.tianocore.org/show_bug.cgi?id=2308 Signed-off-by: Mike Beaton --- .../Include/AcpiDebugFeature.dsc | 5 +---- .../Include/NetworkFeature.dsc | 5 +---- .../AsfFeaturePkg/Include/AsfFeature.dsc | 10 ++-------- .../IpmiFeaturePkg/Include/IpmiFeature.dsc | 10 ++-------- .../SpcrFeaturePkg/Include/SpcrFeature.dsc | 5 +---- .../Include/PlatformPayloadFeature.dsc | 5 +---- .../S3FeaturePkg/Include/S3Feature.dsc | 10 ++-------- .../SmbiosFeaturePkg/Include/SmbiosFeature.dsc | 5 +---- .../Include/TemplateFeature.dsc | 10 ++-------- .../LogoFeaturePkg/Include/LogoFeature.dsc | 5 +---- .../Include/UserAuthFeature.dsc | 5 +---- .../CometlakeURvp/OpenBoardPkg.dsc | 16 ++++------------ .../AspireVn7Dash572G/OpenBoardPkg.dsc | 17 ++++------------- .../GalagoPro3/OpenBoardPkg.dsc | 16 ++++------------ .../KabylakeRvp3/OpenBoardPkg.dsc | 17 ++++------------- .../BoardX58Ich10/OpenBoardPkg.dsc | 8 ++------ .../UpXtreme/OpenBoardPkg.dsc | 16 ++++------------ .../WhiskeylakeURvp/OpenBoardPkg.dsc | 16 ++++------------ 18 files changed, 41 insertions(+), 140 deletions(-) diff --git a/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.dsc b/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.dsc index 684549bbdd7..e8eaffaad3c 100644 --- a/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.dsc +++ b/Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.dsc @@ -42,10 +42,7 @@ # # Feature DXE Components # - -# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308 -# is completed. -[Components.X64] +[Components.$(DXE_ARCH)] ##################################### # ACPI Debug Feature Package ##################################### diff --git a/Features/Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.dsc b/Features/Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.dsc index ca151b4e33f..51646d5eb98 100644 --- a/Features/Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.dsc +++ b/Features/Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.dsc @@ -63,10 +63,7 @@ # # Feature DXE Components # - -# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308 -# is completed. -[Components.X64] +[Components.$(DXE_ARCH)] ##################################### # Network Feature Package ##################################### diff --git a/Features/Intel/OutOfBandManagement/AsfFeaturePkg/Include/AsfFeature.dsc b/Features/Intel/OutOfBandManagement/AsfFeaturePkg/Include/AsfFeature.dsc index d76ab30008c..54f69da7e03 100644 --- a/Features/Intel/OutOfBandManagement/AsfFeaturePkg/Include/AsfFeature.dsc +++ b/Features/Intel/OutOfBandManagement/AsfFeaturePkg/Include/AsfFeature.dsc @@ -36,17 +36,11 @@ # # Feature PEI Components # - -# @todo: Change below line to [Components.$(PEI_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308 -# is completed. -[Components.IA32] +[Components.$(PEI_ARCH)] AsfFeaturePkg/AsfPei/AsfPei.inf # # Feature DXE Components # - -# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308 -# is completed. -[Components.X64] +[Components.$(DXE_ARCH)] AsfFeaturePkg/AsfDxe/AsfDxe.inf diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc index bf824446906..162627b76d6 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc @@ -82,10 +82,7 @@ # # Feature PEI Components # - -# @todo: Change below line to [Components.$(PEI_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308 -# is completed. -[Components.IA32] +[Components.$(PEI_ARCH)] ##################################### # IPMI Feature Package ##################################### @@ -106,10 +103,7 @@ # # Feature DXE Components # - -# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308 -# is completed. -[Components.X64] +[Components.$(DXE_ARCH)] ##################################### # IPMI Feature Package ##################################### diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeature.dsc b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeature.dsc index b06ddf4fe62..78fab7cfe6f 100644 --- a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeature.dsc +++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeature.dsc @@ -42,8 +42,5 @@ # generated for it, but the binary will not be put into any firmware volume. # ################################################################################ - -# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308 -# is completed. -[Components.X64] +[Components.$(DXE_ARCH)] SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpiDxe.inf diff --git a/Features/Intel/PlatformPayloadFeaturePkg/Include/PlatformPayloadFeature.dsc b/Features/Intel/PlatformPayloadFeaturePkg/Include/PlatformPayloadFeature.dsc index 8056b06548a..7871e7c08bc 100644 --- a/Features/Intel/PlatformPayloadFeaturePkg/Include/PlatformPayloadFeature.dsc +++ b/Features/Intel/PlatformPayloadFeaturePkg/Include/PlatformPayloadFeature.dsc @@ -71,10 +71,7 @@ # # Feature DXE Components # - -# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308 -# is completed. -[Components.X64] +[Components.$(DXE_ARCH)] # # SMM Variable Support # diff --git a/Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc b/Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc index 29e8f9e8530..a7c15413e45 100644 --- a/Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc +++ b/Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc @@ -63,10 +63,7 @@ # # Feature PEI Components # - -# @todo: Change below line to [Components.$(PEI_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308 -# is completed. -[Components.IA32] +[Components.$(PEI_ARCH)] ##################################### # S3 Feature Package ##################################### @@ -79,10 +76,7 @@ # # Feature DXE Components # - -# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308 -# is completed. -[Components.X64] +[Components.$(DXE_ARCH)] ##################################### # S3 Feature Package ##################################### diff --git a/Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/SmbiosFeature.dsc b/Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/SmbiosFeature.dsc index 7a165f39d78..75bda9b7469 100644 --- a/Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/SmbiosFeature.dsc +++ b/Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/SmbiosFeature.dsc @@ -51,10 +51,7 @@ # # Feature DXE Components # - -# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308 -# is completed. -[Components.X64] +[Components.$(DXE_ARCH)] ##################################### # SMBIOS Feature Package ##################################### diff --git a/Features/Intel/TemplateFeaturePkg/Include/TemplateFeature.dsc b/Features/Intel/TemplateFeaturePkg/Include/TemplateFeature.dsc index dd6d033aca2..0161c4ccc95 100644 --- a/Features/Intel/TemplateFeaturePkg/Include/TemplateFeature.dsc +++ b/Features/Intel/TemplateFeaturePkg/Include/TemplateFeature.dsc @@ -68,10 +68,7 @@ # # Feature PEI Components # - -# @todo: Change below line to [Components.$(PEI_ARCH)] after https://bugzilla.tianocore.org/show_bug.cgi?id=2308 -# is completed. -[Components.IA32] +[Components.$(PEI_ARCH)] ##################################### #