Enable structured chat for Groq models#934
Merged
hadley merged 4 commits intotidyverse:mainfrom Mar 2, 2026
Merged
Conversation
hadley
reviewed
Feb 22, 2026
R/provider-groq.R
Outdated
| description = x@description, | ||
| properties = as_json(provider, x@properties, ...), | ||
| required = as.list(names2(x@properties)[required]) | ||
| required = as.list(names2(x@properties)[required]), |
Member
There was a problem hiding this comment.
Would you mind checking to see if it's now possible to just delete this method? i.e. maybe grok is now sufficiently OpenAI compatible that we don't need any customisation here.
Contributor
Author
There was a problem hiding this comment.
Yes, it looks like both this method and the as_json method for Turn objects are no longer needed. The tool calling and structured data tests pass when using the default OpenAICompatible provider
Member
There was a problem hiding this comment.
Yay, deleting code is my favourite 😄
Member
|
One last thing and we should be good to merge: Can you please add a bullet to the top of |
Contributor
Author
|
Thanks for your patience! |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #930.
I added a test for this use case, which requires using a different model than the default. The existing test doesn't require a different default, so I wasn't sure if I should add a
chat_groq_test()function like some other providers have. I also notice the tool-calling test doesn't seem to reliably pass with the default model.