Skip to content

Commit b64bf47

Browse files
Remove @embroider/util (#123)
* wip * Re-add cast * Update lockfile * Fix cast
1 parent 1cc7e7a commit b64bf47

File tree

5 files changed

+60
-44
lines changed

5 files changed

+60
-44
lines changed

ember-element-helper/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ official implementation is available.
1919

2020
## Compatibility
2121

22-
* Ember.js v3.24 or above
23-
* Ember CLI v3.24 or above
22+
* Ember.js v3.28 or above
23+
* Ember CLI v3.28 or above
2424
* Node.js v12 or above
2525

2626
## Limitations

ember-element-helper/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,7 @@
5454
"prepublishOnly": "pnpm build"
5555
},
5656
"dependencies": {
57-
"@embroider/addon-shim": "^1.8.3",
58-
"@embroider/util": "^1.0.0"
57+
"@embroider/addon-shim": "^1.8.3"
5958
},
6059
"devDependencies": {
6160
"@babel/core": "7.18.6",

ember-element-helper/src/helpers/element.ts

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,11 @@
22
import EmberComponent from '@ember/component';
33
import Helper from '@ember/component/helper';
44
import { assert, runInDebug } from '@ember/debug';
5-
import { ensureSafeComponent } from '@embroider/util';
65

76
import type { ComponentLike } from '@glint/template';
87

98
// eslint-disable-next-line @typescript-eslint/no-empty-function
10-
function UNINITIALIZED() {}
9+
function UNINITIALIZED() { }
1110

1211
export type ElementFromTagName<T extends string> = T extends keyof HTMLElementTagNameMap
1312
? HTMLElementTagNameMap[T]
@@ -43,14 +42,10 @@ export default class ElementHelper<T extends string> extends Helper<ElementSigna
4342
this.tagName = tagName;
4443

4544
if (typeof tagName === 'string') {
46-
this.componentClass = ensureSafeComponent(
47-
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
48-
// @ts-ignore
45+
this.componentClass =
4946
class DynamicElement extends EmberComponent {
50-
tagName = tagName; // eslint-disable-line ember/require-tagless-components
51-
},
52-
this
53-
) as unknown as Return<T>;
47+
tagName = tagName;
48+
} as unknown as Return<T>;
5449
} else {
5550
this.componentClass = undefined;
5651

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
"lint:fix": "pnpm --filter '*' lint:fix",
1313
"test": "pnpm --filter '*' test"
1414
},
15+
"packageManager": "pnpm@8",
1516
"volta": {
1617
"node": "16.20.2",
1718
"npm": "9.8.1"

0 commit comments

Comments
 (0)