Skip to content

Commit d81e0ca

Browse files
authored
test for latest node version (#16)
Signed-off-by: Nick Santos <[email protected]>
1 parent 12045fc commit d81e0ca

File tree

13 files changed

+14
-20
lines changed

13 files changed

+14
-20
lines changed

.circleci/config.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,8 @@ jobs:
66

77
steps:
88
- checkout
9-
- setup_remote_docker:
10-
version: 20.10.11
11-
- run: apt install -y python
9+
- setup_remote_docker
10+
- run: apt install -y python3
1211
- run: apt install -y npm
1312
- run: npm install -g yarn
1413
- run: ctlptl create cluster kind --registry=ctlptl-registry && test/test.sh

0-base/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM node:10
1+
FROM node:20
22

33
WORKDIR /app
44

0-base/Tiltfile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@ k8s_resource('example-nodejs', port_forwards=8000,
1010
# shows you how to set up a custom workflow that measures it.
1111
local_resource(
1212
'deploy',
13-
'python now.py > start-time.txt',
13+
'python3 now.py > start-time.txt',
1414
)
1515

1616
docker_build('example-nodejs-image', '.')
17-

1-measured/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM node:10
1+
FROM node:20
22

33
WORKDIR /app
44

1-measured/Tiltfile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@ k8s_resource('example-nodejs', port_forwards=8000,
1010
# shows you how to set up a custom workflow that measures it.
1111
local_resource(
1212
'deploy',
13-
'python now.py > start-time.txt',
13+
'python3 now.py > start-time.txt',
1414
)
1515

1616
docker_build('example-nodejs-image', '.')
17-

101-debugger/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM node:10
1+
FROM node:20
22

33
# Default value; will be overridden by build_args, if passed
44
ARG node_env=production

101-debugger/Tiltfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ k8s_resource('example-nodejs', port_forwards=[
1313
# shows you how to set up a custom workflow that measures it.
1414
local_resource(
1515
'deploy',
16-
'python now.py > start-time.txt',
16+
'python3 now.py > start-time.txt',
1717
)
1818

1919
# Add a live_update rule to our docker_build

2-optimized-dockerfile/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM node:10
1+
FROM node:20
22

33
WORKDIR /app
44

2-optimized-dockerfile/Tiltfile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@ k8s_resource('example-nodejs', port_forwards=8000,
1010
# shows you how to set up a custom workflow that measures it.
1111
local_resource(
1212
'deploy',
13-
'python now.py > start-time.txt',
13+
'python3 now.py > start-time.txt',
1414
)
1515

1616
docker_build('example-nodejs-image', '.')
17-

3-recommended/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM node:10
1+
FROM node:20
22

33
# Default value; will be overridden by build_args, if passed
44
ARG node_env=production

3-recommended/Tiltfile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ k8s_resource('example-nodejs', port_forwards=8000,
1010
# shows you how to set up a custom workflow that measures it.
1111
local_resource(
1212
'deploy',
13-
'python now.py > start-time.txt',
13+
'python3 now.py > start-time.txt',
1414
)
1515

1616
# Add a live_update rule to our docker_build
@@ -30,4 +30,3 @@ docker_build('example-nodejs-image', '.',
3030
run('sed -i "s/Hello cats!/{}/g" /app/views/index.mustache'.
3131
format(congrats)),
3232
])
33-

tests-example/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM node:10
1+
FROM node:20
22

33
# Default value; will be overridden by build_args, if passed
44
ARG node_env=production

tests-example/Tiltfile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ k8s_resource('example-nodejs', port_forwards=8000,
1313
# shows you how to set up a custom workflow that measures it.
1414
local_resource(
1515
'deploy',
16-
'python now.py > start-time.txt',
16+
'python3 now.py > start-time.txt',
1717
)
1818

1919
# Add a live_update rule to our docker_build
@@ -33,4 +33,3 @@ docker_build('example-nodejs-image', '.',
3333
run('sed -i "s/Hello cats!/{}/g" /app/views/index.mustache'.
3434
format(congrats)),
3535
])
36-

0 commit comments

Comments
 (0)