remove NoInfer from optimisticFn arg

Author: tim-smart

.changeset/loud-ties-press.md

@@ -0,0 +1,8 @@
+---
+"@effect-rx/rx": patch
+"@effect-rx/rx-livestore": patch
+"@effect-rx/rx-react": patch
+"@effect-rx/rx-vue": patch
+---
+
+remove NoInfer from optimisticFn arg

docs/rx/Rx.ts.md

@@ -255,19 +255,15 @@ Added in v1.0.0
 
 ```ts
 export declare const optimisticFn: {
-  <A, W, XA, XE, OW = W>(options: {
+  <A, W, XA, XE, OW = void>(options: {
     readonly reducer: (current: NoInfer<A>, update: OW) => NoInfer<W>
-    readonly fn:
-      | RxResultFn<NoInfer<OW>, XA, XE>
-      | ((set: (result: NoInfer<W>) => void) => RxResultFn<NoInfer<OW>, XA, XE>)
+    readonly fn: RxResultFn<OW, XA, XE> | ((set: (result: NoInfer<W>) => void) => RxResultFn<OW, XA, XE>)
   }): (self: Writable<A, Rx<Result.Result<W, unknown>>>) => RxResultFn<OW, XA, XE>
-  <A, W, XA, XE, OW = W>(
+  <A, W, XA, XE, OW = void>(
     self: Writable<A, Rx<Result.Result<W, unknown>>>,
     options: {
       readonly reducer: (current: NoInfer<A>, update: OW) => NoInfer<W>
-      readonly fn:
-        | RxResultFn<NoInfer<OW>, XA, XE>
-        | ((set: (result: NoInfer<W>) => void) => RxResultFn<NoInfer<OW>, XA, XE>)
+      readonly fn: RxResultFn<OW, XA, XE> | ((set: (result: NoInfer<W>) => void) => RxResultFn<OW, XA, XE>)
     }
   ): RxResultFn<OW, XA, XE>
 }

packages/rx/src/Rx.ts

@@ -1449,8 +1449,8 @@ export const optimisticFn: {
     options: {
       readonly reducer: (current: NoInfer<A>, update: OW) => NoInfer<W>
       readonly fn:
-        | RxResultFn<NoInfer<OW>, XA, XE>
-        | ((set: (result: NoInfer<W>) => void) => RxResultFn<NoInfer<OW>, XA, XE>)
+        | RxResultFn<OW, XA, XE>
+        | ((set: (result: NoInfer<W>) => void) => RxResultFn<OW, XA, XE>)
     }
   ): (
     self: Writable<A, Rx<Result.Result<W, unknown>>>
@@ -1460,17 +1460,17 @@ export const optimisticFn: {
     options: {
       readonly reducer: (current: NoInfer<A>, update: OW) => NoInfer<W>
       readonly fn:
-        | RxResultFn<NoInfer<OW>, XA, XE>
-        | ((set: (result: NoInfer<W>) => void) => RxResultFn<NoInfer<OW>, XA, XE>)
+        | RxResultFn<OW, XA, XE>
+        | ((set: (result: NoInfer<W>) => void) => RxResultFn<OW, XA, XE>)
     }
   ): RxResultFn<OW, XA, XE>
 } = dual(2, <A, W, XA, XE, OW = void>(
   self: Writable<A, Rx<Result.Result<W, unknown>>>,
   options: {
     readonly reducer: (current: NoInfer<A>, update: OW) => NoInfer<W>
     readonly fn:
-      | RxResultFn<NoInfer<OW>, XA, XE>
-      | ((set: (result: NoInfer<W>) => void) => RxResultFn<NoInfer<OW>, XA, XE>)
+      | RxResultFn<OW, XA, XE>
+      | ((set: (result: NoInfer<W>) => void) => RxResultFn<OW, XA, XE>)
   }
 ): RxResultFn<OW, XA, XE> => {
   const transition = state<Result.Result<W, unknown>>(Result.initial())

packages/rx/test/Rx.test.ts

@@ -1124,8 +1124,8 @@ describe("Rx", () => {
       )
       const fn = optimisticRx.pipe(
         Rx.optimisticFn({
-          reducer: (_, value: number) => value,
-          fn: Rx.fn(Effect.fnUntraced(function*() {
+          reducer: (_, value) => value,
+          fn: Rx.fn<number>()(Effect.fnUntraced(function*() {
             yield* latch.await
             return yield* Effect.fail("error")
           }))
@@ -1156,8 +1156,8 @@ describe("Rx", () => {
       const optimisticRx = rx.pipe(Rx.optimistic, Rx.keepAlive)
       const fn = optimisticRx.pipe(
         Rx.optimisticFn({
-          reducer: (_current, update: number) => update,
-          fn: Rx.fn(() => {
+          reducer: (_current, update) => update,
+          fn: Rx.fn<number>()(() => {
             i = 2
             return Effect.void
           })