small fixes

Author: krausest

eslint.config.js

@@ -44,7 +44,7 @@ export default tseslint.config(
    * Webdriver
    */
   {
-    files: ["webdriver-ts/**/*.{js,cjs,ts}"],
+    files: ["webdriver-ts/src/**/*.{js,cjs,ts}"],
     languageOptions: {
       parserOptions: { project: ["./webdriver-ts/tsconfig.eslint.json"] },
     },
@@ -53,6 +53,7 @@ export default tseslint.config(
       "require-await": "error",
       "@typescript-eslint/no-floating-promises": "error",
       "@typescript-eslint/no-unused-vars": "off",
+      "prefer-const": "off",
     },
   },
   /**
@@ -83,7 +84,7 @@ export default tseslint.config(
     },
   },
   {
-    ignores: ["**/node_modules/", "**/dist/", "**/results/", "css/", "**/csv_export.js"],
+    ignores: ["**/node_modules/", "**/dist/", "**/results/", "css/", "**/csv_export.js", "**/py/"],
   },
   eslintConfigPrettier
 );

package.json

@@ -9,7 +9,7 @@
     "build": "echo \"Please use 'npm run rebuild-all' instead\" && exit 1",
     "build-prod": "echo \"Please use 'npm run rebuild-all' instead\" && exit 1",
     "compile": "echo \"Please use 'npm run rebuild-all' instead\" && exit 1",
-    "start": "cd server && node index.js",
+    "start": "cd server && npm start",
     "bench": "cd webdriver-ts && cross-env LANG=\"en_US.UTF-8\" node dist/benchmarkRunner.js",
     "checkCSP": "cd webdriver-ts && cross-env LANG=\"en_US.UTF-8\" node dist/isCSPCompliant.js",
     "results": "cd webdriver-ts && npm run results",

webdriver-ts/src/benchmarkRunner.ts

@@ -340,7 +340,7 @@ async function main() {
     benchmarkOptions.numIterationsForStartupBenchmark = args.count;
   }
 
-  let allArgs = args._.length <= 2 ? [] : args._.slice(2, args._.length);
+  let allArgs = args._.length <= 2 ? [] : args._.slice(2);
   let frameworkArgument = args.framework ? args.framework : allArgs;
   console.log("args", args, "allArgs", allArgs);
 

webdriver-ts/src/isCSPCompliant.ts

@@ -36,7 +36,7 @@ let benchmarkOptions: BenchmarkOptions = {
   allowThrottling: !args.nothrottling,
 };
 
-let allArgs = args._.length <= 2 ? [] : args._.slice(2, args._.length);
+let allArgs = args._.length <= 2 ? [] : args._.slice(2);
 
 console.log("args.framework", args.framework, !args.framework);
 
@@ -89,7 +89,7 @@ async function runBench(
         cspCheckSucessful = false;
         console.log(`CSP test failed for ${runFrameworks[i].fullNameWithKeyedAndVersion} - due to reporting`);
       }
-      if (!cspCheckSucessful != framework.issues.includes((1139))) {
+      if (cspCheckSucessful == framework.issues.includes((1139))) {
         const hint = cspCheckSucessful ? "The flag 1139 should be removed" : "The flag 1139 should be added";
         console.log(`ERROR: CSP is incorrectly categorized for ${runFrameworks[i].fullNameWithKeyedAndVersion} . ${hint}`);
         cspCheckSucessful = false;

webdriver-ts/src/isKeyed.ts

@@ -39,7 +39,7 @@ let benchmarkOptions: BenchmarkOptions = {
   allowThrottling: !args.nothrottling,
 };
 
-let allArgs = args._.length <= 2 ? [] : args._.slice(2, args._.length);
+let allArgs = args._.length <= 2 ? [] : args._.slice(2);
 let frameworkArgument = args.framework ? args.framework : allArgs;
 console.log("args", args, "allArgs", allArgs);
 

webdriver-ts/src/playwrightAccess.ts

@@ -98,6 +98,7 @@ function browserPath(benchmarkOptions: BenchmarkOptions) {
   } else if (process.platform == "linux") {
     return "/usr/bin/google-chrome";
   } else if (/^win/i.test(process.platform)) {
+    // eslint-disable-next-line unicorn/prefer-string-raw
     return "C:\\Program Files\\Google\\Chrome\\Application\\chrome.exe";
   } else {
     throw new Error("Path to Google Chrome executable must be specified");

webdriver-ts/src/puppeteerAccess.ts

@@ -1,8 +1,6 @@
 import * as puppeteer from "puppeteer-core";
 import { Page } from "puppeteer-core";
 import { BenchmarkOptions, wait } from "./common.js";
-import * as fs from "node:fs";
-import * as path from "node:path";
 
 export async function checkElementNotExists(page: Page, selector: string) {
   let start = Date.now();
@@ -99,6 +97,7 @@ function browserPath(benchmarkOptions: BenchmarkOptions) {
   } else if (process.platform == "linux") {
     return "google-chrome";
   } else if (/^win/i.test(process.platform)) {
+    // eslint-disable-next-line unicorn/prefer-string-raw
     return "C:\\Program Files\\Google\\Chrome\\Application\\chrome.exe";
   } else {
     throw new Error("Path to Google Chrome executable must be specified");