Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows and Linux Support for ctrl-k #5

Open
markjfisher opened this issue Oct 20, 2024 · 16 comments
Open

Add Windows and Linux Support for ctrl-k #5

markjfisher opened this issue Oct 20, 2024 · 16 comments

Comments

@markjfisher
Copy link

I'm not sure why #2 was closed, but this extension is not working with windows pressing ctrl-k to delete a line (for example)

Instead I get the cursor pop up:
image

Please add support for windows/linux keybindings.
Thanks.

@DK013
Copy link

DK013 commented Oct 21, 2024

Same issue here

@tjx666
Copy link
Owner

tjx666 commented Oct 21, 2024

I don't have windows computer, would you help provide some information to help debug?

  1. disable this extension, restart vscode and run command Preferences: Open Default Keyboard Shortcuts (JSON)(ctrl + shift + p` to open command palatte), provide me the json content
  2. enable this extension, run the command again, and provide me the json content again
image

@markjfisher @DK013

@markjfisher
Copy link
Author

keybindings.json

@tjx666
Copy link
Owner

tjx666 commented Oct 21, 2024

@markjfisher @DK013 please try latest version v1.0.0

cursor extension market is slow than vscode extension market, maybe need to wait some minutes to see latest version.

@markjfisher
Copy link
Author

I'll try it as soon as it shows. Still showing 0.1.1 at the moment.

@markjfisher
Copy link
Author

It shows in the list if you pick specific version, just not in the changelog...

@markjfisher
Copy link
Author

delete line is working in 1.0.0, thanks.

@tjx666
Copy link
Owner

tjx666 commented Oct 21, 2024

@markjfisher Terminal can be clear by ctrl + k ?

@markjfisher
Copy link
Author

Yes, I typed something on the cmd line (I use msys2), pressed ctrl-a, ctrl-k and it went to start of line and deleted to the end of the line.
did same half way across the line (alt-b to move backwards a couple of words), typed ctrl-k and it delete to the end of line as I expected.

@tjx666
Copy link
Owner

tjx666 commented Oct 21, 2024

thanks for help debug

@tjx666 tjx666 closed this as completed Oct 21, 2024
@DK013
Copy link

DK013 commented Oct 22, 2024

@tjx666 some issues still persist. like the combinations of ctrl+K commands still doesn't work.
for example:
comment: CTRL+K CTRL+C
uncomment: CTRL+K CTRL+U
etc.

@tjx666
Copy link
Owner

tjx666 commented Oct 22, 2024

@DK013 I will fix it tonight, cursor map some the ctrl + k to ctrl + m on windows, which is different with cmd + k mapped to cmd + r on macos.

image

@tjx666 tjx666 reopened this Oct 22, 2024
@tjx666
Copy link
Owner

tjx666 commented Oct 22, 2024

@DK013 Can you help provide the json after run command Preferences: Open Default Keyboard Shortcuts (JSON)?

@iscodingeasyornot
Copy link

Cursor mod said

In Cursor, Cmd/Ctrl+K is used for the inline edits. We therefore changed the keychord leader key to be Cmd+R on Mac and Ctrl+M on Windows and Linux. For example, “Unfold all” is Cmd+R Cmd+J on Mac and Ctrl+M Ctrl+J on Windows and Linux.

so on Windows or Linux the leader key is ctrl+M instead of R.
And when I want to switch theme I found ctrl+k ctrl+t not working, search 'theme' on the page found the plugin binds ctrl+k windows+t, which should be ctrl+t
image

@tjx666
Copy link
Owner

tjx666 commented Oct 23, 2024

please try latest v1.0.1

image

@DK013
Copy link

DK013 commented Oct 24, 2024

@DK013 Can you help provide the json after run command Preferences: Open Default Keyboard Shortcuts (JSON)?

Sorry for the late reply. Here you go (v1.0.1 didn't fix the functions I gave in example):
Original VSCode key bindings: https://gist.github.com/DK013/fb25fbf463137c4ecc69c54b875511c1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants