remove the ffi feature

Author: tmthecoder

CHANGELOG.md

@@ -1,3 +1,6 @@
+## 0.3.6
+- Remove the "ffi" feature as it was incompatible with the structs. Passing them as an opaque pointer is a better idea.
+
 ## 0.2.0
 - Support parsing an HOTP/TOTP instance from an otpauth URI (Thanks to [@orion78fr](https://github.com/orion78fr))
 - Add in an "ffi" feature to make all structs & enums C-compatible with the `#[repr(C)]` attribute

Cargo.toml

@@ -7,13 +7,9 @@ license = "MIT"
 keywords = ["otp", "hotp", "totp", "otpauth"]
 categories = ["cryptography"]
 authors = ["Tejas Mehta <[email protected]>"]
-version = "0.2.0"
+version = "0.3.0"
 edition = "2021"
 
-[features]
-default = []
-ffi = []
-
 [dependencies]
 hmac = "0.12.0"
 sha-1 = "0.10.0"

src/hotp.rs

@@ -18,7 +18,6 @@ use crate::util::{base32_decode, get_code, hash_generic, MacDigest};
 /// [RFC4226]: https://datatracker.ietf.org/doc/html/rfc4226
 
 #[derive(Debug, Clone, Hash)]
-#[cfg_attr(feature = "ffi", repr(C))]
 pub struct HOTP {
     /// The secret key used in the HMAC process.
     ///

src/totp.rs

@@ -16,7 +16,6 @@ use crate::util::{base32_decode, get_code, hash_generic, MacDigest};
 ///
 /// [RFC6238]: https://datatracker.ietf.org/doc/html/rfc6238
 #[derive(Debug, Clone, Hash)]
-#[cfg_attr(feature = "ffi", repr(C))]
 pub struct TOTP {
     /// The secret key used in the HMAC process.
     ///

src/util.rs

@@ -20,7 +20,6 @@ use crate::totp::TOTP;
 ///
 /// [RFC6238]: https://datatracker.ietf.org/doc/html/rfc6238
 #[derive(Debug, Copy, Clone, Hash, PartialEq, Eq)]
-#[cfg_attr(feature = "ffi", repr(C))]
 pub enum MacDigest {
     SHA1,
     SHA256,
@@ -82,7 +81,6 @@ pub(crate) fn base32_decode(data: &str) -> Option<Vec<u8>> {
 /// If an [HOTP] instance is returned, a second value is returned
 /// signifying the counter's value.
 #[derive(Debug)]
-#[cfg_attr(feature = "ffi", repr(C))]
 pub enum ParseResult {
     TOTP(TOTP),
     HOTP(HOTP, u64),
@@ -94,7 +92,6 @@ pub enum ParseResult {
 /// in an enum. The returned error may have an associated message or
 /// [url::ParseError] with more information
 #[derive(Debug)]
-#[cfg_attr(feature = "ffi", repr(C))]
 pub enum ParseError {
     UriParseError(url::ParseError),
     WrongScheme(String),