Ensure that 'start logging' displays correct filename

Phil Hindman · Phil Hindman · commit 309c8f8e85ec · 2024-05-18T11:27:41.000-05:00
Previously the filename was calculated twice: first when opening the
file, and then when displaying the message.  There is a small chance
that the time would change between those two events, causing the
displayed filename to be incorrect.  This change calculates the name
once and then uses that name in both places.
diff --git a/scripts/toggle_logging.sh b/scripts/toggle_logging.sh
@@ -9,7 +9,7 @@ source "$CURRENT_DIR/shared.sh"
 start_pipe_pane() {
 	local file=$(expand_tmux_format_path "${logging_full_filename}")
 	"$CURRENT_DIR/start_logging.sh" "${file}"
-	display_message "Started logging to ${logging_full_filename}"
+	display_message "Started logging to ${file}"
 }
 
 stop_pipe_pane() {

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ source "$CURRENT_DIR/shared.sh"`
`9`	`9`	`start_pipe_pane() {`
`10`	`10`	`local file=$(expand_tmux_format_path "${logging_full_filename}")`
`11`	`11`	`"$CURRENT_DIR/start_logging.sh" "${file}"`
`12`		`- display_message "Started logging to ${logging_full_filename}"`
	`12`	`+ display_message "Started logging to ${file}"`
`13`	`13`	`}`
`14`	`14`
`15`	`15`	`stop_pipe_pane() {`