Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label updates made via undo (ctrl-z) do not save to DB #59

Closed
nathanielrindlaub opened this issue Jan 2, 2022 · 2 comments
Closed

Label updates made via undo (ctrl-z) do not save to DB #59

nathanielrindlaub opened this issue Jan 2, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@nathanielrindlaub
Copy link
Member

Investigate...

@nathanielrindlaub nathanielrindlaub added the bug Something isn't working label Jan 2, 2022
@nathanielrindlaub nathanielrindlaub self-assigned this Jan 2, 2022
@nathanielrindlaub
Copy link
Member Author

This is a bigger problem than expected. redux-undo does not replay/fire the previous actions, so reviewMiddleware.js can't intercept them, and none of the side effects (i.e. API calls) get triggered. It also appears as though triggering side-effects from redux-undo is not yet supported.

Next step is to look into redux-undo-redo, which sounds promising.

@nathanielrindlaub
Copy link
Member Author

Done. Moved to redux-undo-redo, which should provide better performance across the board b/c we're not storing many copies of state in the undo history. We no longer get the "Application state or actions payloads are too large making Redux DevTools serialization slow and consuming a lot of memory. See https://git.io/fpcP5 on how to configure it." error in the production app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant