Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocksuite Affine module issue for CheckBoxCheckSolidIcon #9050

Open
awaiz331 opened this issue Jan 3, 2025 · 8 comments
Open

Blocksuite Affine module issue for CheckBoxCheckSolidIcon #9050

awaiz331 opened this issue Jan 3, 2025 · 8 comments

Comments

@awaiz331
Copy link

awaiz331 commented Jan 3, 2025

Hello, I am facing this module issue using @blocksuite/affine.

X [ERROR] No matching export in "node_modules/@blocksuite/icons/dist/lit.mjs" for import "CheckBoxCkeckSolidIcon"

node_modules/@blocksuite/affine-components/dist/context-menu/button.js:36:9:
  36 │ import { CheckBoxCkeckSolidIcon, CheckBoxUnIcon, DoneIcon, } from '@blocksuite/icons/lit';
     │          ~~~~~~~~~~~~~~~~~~~~~~
     ╵          CheckBoxCheckSolidIcon

Did you mean to import "CheckBoxCheckSolidIcon" instead?

node_modules/@blocksuite/icons/dist/lit.mjs:4592:24:
  4592 │   CheckBoxCheckSolid as CheckBoxCheckSolidIcon,
       ╵                         ~~~~~~~~~~~~~~~~~~~~~~

X [ERROR] No matching export in "node_modules/@blocksuite/icons/dist/lit.mjs" for import "CheckBoxCkeckSolidIcon"

node_modules/@blocksuite/data-view/dist/core/group-by/renderer/boolean-group.js:1:9:
  1 │ import { CheckBoxCkeckSolidIcon, CheckBoxUnIcon } from '@blocksuite/icons/lit';
    │          ~~~~~~~~~~~~~~~~~~~~~~
    ╵          CheckBoxCheckSolidIcon

Did you mean to import "CheckBoxCheckSolidIcon" instead?

node_modules/@blocksuite/icons/dist/lit.mjs:4592:24:
  4592 │   CheckBoxCheckSolid as CheckBoxCheckSolidIcon,
       ╵                         ~~~~~~~~~~~~~~~~~~~~~~

X [ERROR] No matching export in "node_modules/@blocksuite/icons/dist/lit.mjs" for import "CheckBoxCkeckSolidIcon"

node_modules/@blocksuite/data-view/dist/property-presets/checkbox/cell-renderer.js:36:9:
  36 │ import { CheckBoxCkeckSolidIcon, CheckBoxUnIcon } from '@blocksuite/icons/lit';
     │          ~~~~~~~~~~~~~~~~~~~~~~
     ╵          CheckBoxCheckSolidIcon

Did you mean to import "CheckBoxCheckSolidIcon" instead?

node_modules/@blocksuite/icons/dist/lit.mjs:4592:24:
  4592 │   CheckBoxCheckSolid as CheckBoxCheckSolidIcon,
@KehindeWilliams
Copy link

Following

@KhangGEH
Copy link

KhangGEH commented Jan 6, 2025

Isn't this a typo?

CheckBoxC k eckSolidIcon => should be a h here instead?

@itsjustanks
Copy link

Following as well. It looks like a typo is the cause. Good spotting @KhangGEH. Your best bet @awaiz331 is to fork this repo, apply the fix and use that fork.

@UXDart
Copy link

UXDart commented Feb 16, 2025

what was changed on npm package with same number today? there are no changes in the repo...

@jonsen
Copy link

jonsen commented Feb 19, 2025

My solution:

$ cd node_modules/.pnpm
$ grep -r CheckBoxCkeckSolidIcon ./@blocksuite+*|awk -F\: '{print $1}'|sort|uniq|xargs sed -i "" -e 's/CheckBoxCkeckSolidIcon/CheckBoxCheckSolidIcon/g'

@KhangGEH
Copy link

KhangGEH commented Feb 19, 2025

My solution:

$ cd node_modules/.pnpm
$ grep -r CheckBoxCkeckSolidIcon ./@BlockSuite+*|awk -F: '{print $1}'|sort|uniq|xargs sed -i "" -e 's/CheckBoxCkeckSolidIcon/CheckBoxCheckSolidIcon/g'

Feel a bit hacky but if the authors refused to maintain/update this, what else can we do? ¯\(ツ)

@UXDart
Copy link

UXDart commented Feb 19, 2025

thing is this is MPL which means you need make public your changes, is not that is not simple to fix, is that it seems this package can't be used anymore. better to move on. bad thing is that I would pay to use it... it is clear they don't want that also

@yuzh2001
Copy link

yuzh2001 commented Feb 27, 2025

Provides a easier way to fix above issue, manually pnpm i @blocksuite/[email protected] would do.
Seems that this typo is fixed on @blocksuite/[email protected], while the other packages didn't follow the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

7 participants