Delete debug-only AuthProvider.notify-created.

The AuthProvider-side notify-created was documented as 'mostly for
debugging purposes' and just appended a {'type': 'created'} event row.
Nothing depends on that event, and the lone caller in fleet.toit
already inserts the same kind of state through the broker's own (and
load-bearing) notify-created.

Removes:
- the interface declaration in auth-provider.toit;
- the Supabase and HTTP impls;
- the fleet.toit caller and its 'mostly for testing purposes' comment;
- the HTTP test server dispatch branch;
- the COMMAND-NOTIFY-ARTEMIS-CREATED_ constant and its string mapping;
- the test-notify-created test helper.

The broker's own notify-created (BrokerCli.notify-created) is untouched.

Author: floitsch

src/cli/artemis.toit

@@ -77,10 +77,6 @@ class Artemis:
   ensure-authenticated -> none:
     connected-auth-provider_
 
-  notify-created --hardware-id/Uuid:
-    server := connected-auth-provider_
-    server.notify-created --hardware-id=hardware-id
-
   create-device --device-id/Uuid? --organization-id/Uuid -> Device:
     return connected-auth-provider_.create-device-in-organization
         --device-id=device-id

src/cli/auth_providers/auth-provider.toit

@@ -68,14 +68,6 @@ interface AuthProvider implements Authenticatable:
   */
   create-device-in-organization --organization-id/Uuid --device-id/Uuid? -> Device
 
-  /**
-  Notifies the server that the device with the given $hardware-id was created.
-
-  This operation is mostly for debugging purposes, as the $create-device-in-organization
-    already has a similar effect.
-  */
-  notify-created --hardware-id/Uuid
-
   /** Returns the used-id of the authenticated user. */
   get-current-user-id -> string
 

src/cli/auth_providers/http/base.toit

@@ -87,12 +87,6 @@ class AuthProviderHttpToit implements AuthProvider:
         --id=Uuid.parse device-info["alias"]
         --organization-id=Uuid.parse device-info["organization_id"]
 
-  notify-created --hardware-id/Uuid -> none:
-    send-request_ COMMAND-NOTIFY-ARTEMIS-CREATED_ {
-      "hardware_id": "$hardware-id",
-      "data": { "type": "created" },
-    }
-
   get-current-user-id -> Uuid:
     return current-user-id_
 

src/cli/auth_providers/supabase/supabase.toit

@@ -73,12 +73,6 @@ class AuthProviderSupabase implements AuthProvider:
         --id=Uuid.parse inserted["alias"]
         --organization-id=Uuid.parse inserted["organization_id"]
 
-  notify-created --hardware-id/Uuid -> none:
-    client_.rest.insert "events" --no-return-inserted {
-      "device_id": "$hardware-id",
-      "data": { "type": "created" }
-    }
-
   get-current-user-id -> Uuid:
     return Uuid.parse client_.auth.get-current-user["id"]
 

src/cli/fleet.toit

@@ -1041,10 +1041,7 @@ class FleetWithDevices extends Fleet:
         --device-id=device-id
         --organization-id=organization-id
     assert: device.id == device-id
-    hardware-id := device.hardware-id
 
-    // Insert an initial event mostly for testing purposes.
-    artemis.notify-created --hardware-id=hardware-id
     broker.notify-created device
 
     write-identity-file device --out-path=out-path

src/shared/constants.toit

@@ -7,7 +7,6 @@ COMMAND-SIGN-UP_ ::= 2
 COMMAND-SIGN-IN_ ::= 3
 COMMAND-GET-ORGANIZATIONS_ ::= 4
 COMMAND-UPDATE-CURRENT-USER_ ::= 18
-COMMAND-NOTIFY-ARTEMIS-CREATED_ ::= 5
 COMMAND-GET-ORGANIZATION-DETAILS_ ::= 6
 COMMAND-CREATE-ORGANIZATION_ ::= 7
 COMMAND-UPDATE-ORGANIZATION_ ::= 8
@@ -25,7 +24,6 @@ ARTEMIS-COMMAND-TO-STRING ::= {
   COMMAND-SIGN-IN_: "sign-in",
   COMMAND-GET-ORGANIZATIONS_: "get-organizations",
   COMMAND-UPDATE-CURRENT-USER_: "update-current-user",
-  COMMAND-NOTIFY-ARTEMIS-CREATED_: "notify-artemis-created",
   COMMAND-GET-ORGANIZATION-DETAILS_: "get-organization-details",
   COMMAND-CREATE-ORGANIZATION_: "create-organization",
   COMMAND-UPDATE-ORGANIZATION_: "update-organization",
@@ -46,12 +44,7 @@ COMMAND-DOWNLOAD-PRIVATE_ ::= 3
 // As of 2024-03-22 unused. Newer CLIs use $COMMAND-UPDATE-GOALS_ instead.
 COMMAND-UPDATE-GOAL_ ::= 4
 COMMAND-GET-DEVICES_ ::= 5
-/**
-Command to notify the Artemis server that a broker has been created.
-
-To avoid accidental confusion with $COMMAND-NOTIFY-ARTEMIS-CREATED_, the
-  command has the same constants.
-*/
+/** Command to notify the broker that a device has been created. */
 COMMAND-NOTIFY-BROKER-CREATED_ ::= 6
 COMMAND-GET-EVENTS_ ::= 7
 COMMAND-UPDATE-GOALS_ ::= 8

tests/auth-provider-test.toit

@@ -39,13 +39,12 @@ run-test artemis-server/TestArtemisServer [--authenticate]:
     network := net.open
     server-cli := AuthProvider network server-config --cli=cli
     authenticate.call server-cli
-    hardware-id := test-create-device-in-organization server-cli backdoor
-    test-notify-created server-cli backdoor --hardware-id=hardware-id
+    test-create-device-in-organization server-cli backdoor
 
     test-organizations server-cli backdoor
     test-profile server-cli backdoor
 
-test-create-device-in-organization server-cli/AuthProvider backdoor/ArtemisServerBackdoor -> Uuid:
+test-create-device-in-organization server-cli/AuthProvider backdoor/ArtemisServerBackdoor:
   // Test without and with alias.
   device1 := server-cli.create-device-in-organization
       --device-id=null
@@ -66,13 +65,6 @@ test-create-device-in-organization server-cli/AuthProvider backdoor/ArtemisServe
   expect-equals TEST-ORGANIZATION-UUID data[1]
   expect-equals alias-id data[2]
 
-  return hardware-id2
-
-test-notify-created server-cli/AuthProvider backdoor/ArtemisServerBackdoor --hardware-id/Uuid:
-  expect-not (backdoor.has-event --hardware-id=hardware-id --type="created")
-  server-cli.notify-created --hardware-id=hardware-id
-  expect (backdoor.has-event --hardware-id=hardware-id --type="created")
-
 test-organizations server-cli/AuthProvider backdoor/ArtemisServerBackdoor:
   original-orgs := server-cli.get-organizations
 

tools/http_servers/artemis-server.toit

@@ -103,8 +103,6 @@ class HttpArtemisServer extends HttpServer:
       return store-event data
     if command == COMMAND-CREATE-DEVICE-IN-ORGANIZATION_:
       return create-device-in-organization data
-    if command == COMMAND-NOTIFY-ARTEMIS-CREATED_:
-      return store-event data
     if command == COMMAND-SIGN-UP_:
       return sign-up data
     if command == COMMAND-SIGN-IN_: