Skip to content

Commit 3546cac

Browse files
Revert Manage Themes dialog group/theme name input change (#2883)
* revert manage themes group/theme input column * fix themes no_group label for rename group textinput --------- Co-authored-by: macintoshhelper <[email protected]>
1 parent b3e8d67 commit 3546cac

File tree

3 files changed

+32
-19
lines changed

3 files changed

+32
-19
lines changed

packages/tokens-studio-for-figma/src/app/components/ManageThemesModal/CreateOrEditThemeForm.tsx

+15-12
Original file line numberDiff line numberDiff line change
@@ -100,13 +100,12 @@ export const CreateOrEditThemeForm: React.FC<React.PropsWithChildren<React.Props
100100
onClick={onCancel}
101101
/>
102102
<Stack
103-
direction="column"
104-
align="start"
103+
direction="row"
104+
align="center"
105105
gap={1}
106106
css={{
107107
width: '100%',
108-
paddingBlock: '$2',
109-
minHeight: 'calc( (2 * $controlMedium) + $2 )',
108+
paddingBlock: '$4',
110109
justifyContent: 'space-evenly',
111110
}}
112111
>
@@ -118,6 +117,7 @@ export const CreateOrEditThemeForm: React.FC<React.PropsWithChildren<React.Props
118117
autofocus
119118
data-testid="create-or-edit-theme-form--group--name"
120119
{...register('group')}
120+
placeholder="Add group"
121121
css={{
122122
display: 'flex',
123123
}}
@@ -142,7 +142,7 @@ export const CreateOrEditThemeForm: React.FC<React.PropsWithChildren<React.Props
142142
) : (
143143
<Button
144144
data-testid="button-manage-themes-modal-new-group"
145-
variant="invisible"
145+
variant="secondary"
146146
icon={<IconPlus />}
147147
onClick={handleAddGroup}
148148
size="small"
@@ -155,13 +155,16 @@ export const CreateOrEditThemeForm: React.FC<React.PropsWithChildren<React.Props
155155
</Box>
156156
)
157157
}
158-
<Box>/</Box>
158+
<Box css={{ margin: '0 $3' }}>/</Box>
159+
</Stack>
160+
<Stack direction="row" gap={1} align="center" css={{ flexGrow: 1 }}>
161+
<Input
162+
full
163+
data-testid="create-or-edit-theme-form--input--name"
164+
{...register('name', { required: true })}
165+
placeholder="Theme name"
166+
/>
159167
</Stack>
160-
<Input
161-
full
162-
data-testid="create-or-edit-theme-form--input--name"
163-
{...register('name', { required: true })}
164-
/>
165168
</Stack>
166169

167170
</StyledCreateOrEditThemeFormHeaderFlex>
@@ -175,7 +178,7 @@ export const CreateOrEditThemeForm: React.FC<React.PropsWithChildren<React.Props
175178
)}
176179
<Stack direction="column" gap={1}>
177180
{activeTab === ThemeFormTabs.SETS && (
178-
<Stack direction="column" gap={1} css={{ padding: '0 $4 $3' }}>
181+
<Stack direction="column" gap={1} css={{ padding: '$3 $4 $3' }}>
179182
<TokenSetTreeContent
180183
items={treeOrListItems}
181184
renderItemContent={TokenSetThemeItemInput}

packages/tokens-studio-for-figma/src/app/components/ManageThemesModal/ThemeGroupDropDownMenu.tsx

+15-5
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import React, { useCallback } from 'react';
22
import { Check } from 'iconoir-react';
3-
import { DropdownMenu } from '@tokens-studio/ui';
3+
import { Button, DropdownMenu } from '@tokens-studio/ui';
44
import { useTranslation } from 'react-i18next';
55
import Box from '../Box';
66
import { IconPlus } from '@/icons';
@@ -41,14 +41,24 @@ export const ThemeGroupDropDownMenu: React.FC<React.PropsWithChildren<React.Prop
4141

4242
return (
4343
<DropdownMenu>
44-
<DropdownMenu.Trigger>
44+
<DropdownMenu.Trigger asChild>
4545
{
4646
selectedGroup ? (
47-
<span>{selectedGroup}</span>
47+
<Button variant="secondary" asDropdown>
48+
<span>{selectedGroup}</span>
49+
</Button>
4850
) : (
4951
<Box css={{ display: 'flex', alignItems: 'center', gap: '$2' }}>
50-
<IconPlus />
51-
Add&nbsp;group
52+
<Button
53+
data-testid="button-manage-themes-modal-group-dropdown"
54+
variant="secondary"
55+
icon={<IconPlus />}
56+
size="small"
57+
css={{ display: 'flex', alignItems: 'center', height: '28px' }}
58+
asDropdown
59+
>
60+
Add&nbsp;group
61+
</Button>
5262
</Box>
5363
)
5464
}

packages/tokens-studio-for-figma/src/app/components/ManageThemesModal/ThemeListGroupHeader.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import React, {
33
} from 'react';
44
import { useDispatch, useSelector } from 'react-redux';
55
import { IconButton } from '@tokens-studio/ui';
6-
import { styled } from '@stitches/react';
76
import { editProhibitedSelector } from '@/selectors';
87
import { DragControlsContext } from '@/context';
98
import { StyledDragButton } from '../StyledDragger/StyledDragButton';
@@ -13,6 +12,7 @@ import Box from '../Box';
1312
import Input from '../Input';
1413
import IconPencil from '@/icons/pencil.svg';
1514
import { Dispatch } from '@/app/store';
15+
import { INTERNAL_THEMES_NO_GROUP } from '@/constants/InternalTokenGroup';
1616

1717
type Props = React.PropsWithChildren<{
1818
groupName: string
@@ -28,7 +28,7 @@ export function ThemeListGroupHeader({
2828
const dispatch = useDispatch<Dispatch>();
2929
const dragContext = useContext(DragControlsContext);
3030
const editProhibited = useSelector(editProhibitedSelector);
31-
const [currentGroupName, setCurrentGroupName] = useState(label);
31+
const [currentGroupName, setCurrentGroupName] = useState<string>(groupName === INTERNAL_THEMES_NO_GROUP ? '' : groupName);
3232
const [isEditing, setIsEditing] = useState(false);
3333
const handleDragStart = useCallback((event: React.PointerEvent<HTMLDivElement>) => {
3434
dragContext.controls?.start(event);

0 commit comments

Comments
 (0)