-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed not being able to drag nodes at same Y position as the toolbar #636
Conversation
🦋 Changeset detectedLatest commit: ae50f8b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
@@ -821,6 +821,7 @@ export const EditorApp = React.forwardRef< | |||
display: 'grid', | |||
placeItems: 'center', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we are touching this, can we move that css to the modules file?
User description
Description
Fixes #617
Type of change
Screenshots or video (if necessary):
PR Type
Bug fix
Description
Fixed issue preventing node dragging behind toolbar.
Added
pointerEvents: none
to toolbar container style.Ensured toolbar retains interactive pointer events.
Added changeset entry for the fix.
Changes walkthrough 📝
graph.tsx
Adjust toolbar container to allow interactions behind
packages/graph-editor/src/editor/graph.tsx
pointerEvents: none
to toolbar container style.toolbar.module.css
Maintain toolbar interactivity with pointer-events adjustment
packages/graph-editor/src/components/toolbar/toolbar.module.css
pointer-events: auto
for toolbar itself.proud-balloons-remember.md
Add changeset entry for toolbar drag fix
.changeset/proud-balloons-remember.md