Remove more clippy allows

Author: darinmorrison

examples/examples/fmt/yak_shave.rs

@@ -12,8 +12,7 @@ pub fn shave(yak: usize) -> Result<(), Box<dyn Error + 'static>> {
     );
     if yak == 3 {
         warn!(target: "yak_events", "could not locate yak!");
-        #[allow(clippy::try_err)]
-        Err(ShaveError::new(yak, YakError::new("could not locate yak")))?;
+        return Err(ShaveError::new(yak, YakError::new("could not locate yak")).into());
     } else {
         trace!(target: "yak_events", "yak shaved successfully");
     }

tracing-core/src/metadata.rs

@@ -91,7 +91,6 @@ pub struct Level(LevelInner);
 impl<'a> Metadata<'a> {
     /// Construct new metadata for a span or event, with a name, target, level, field
     /// names, and optional source code location.
-    #[allow(clippy::too_many_arguments)]
     pub const fn new(
         name: &'static str,
         target: &'a str,

tracing-subscriber/src/filter/env/directive.rs

@@ -415,10 +415,9 @@ impl<T: Match + Ord> DirectiveSet<T> {
             .filter(move |d| d.cares_about(metadata))
     }
 
-    #[allow(clippy::op_ref)]
     pub(crate) fn add(&mut self, directive: T) {
         let level = directive.level();
-        if level > &self.max_level {
+        if *level > self.max_level {
             self.max_level = level.clone();
         }
         let _ = self.directives.replace(directive);
@@ -434,12 +433,11 @@ impl<T: Match + Ord> FromIterator<T> for DirectiveSet<T> {
 }
 
 impl<T: Match + Ord> Extend<T> for DirectiveSet<T> {
-    #[allow(clippy::op_ref)]
     fn extend<I: IntoIterator<Item = T>>(&mut self, iter: I) {
         let max_level = &mut self.max_level;
         let ds = iter.into_iter().inspect(|d| {
             let level = d.level();
-            if level > &*max_level {
+            if *level > *max_level {
                 *max_level = level.clone();
             }
         });
@@ -450,7 +448,6 @@ impl<T: Match + Ord> Extend<T> for DirectiveSet<T> {
 // === impl Dynamics ===
 
 impl Dynamics {
-    #[allow(clippy::op_ref)]
     pub(crate) fn matcher(&self, metadata: &Metadata<'_>) -> Option<CallsiteMatcher> {
         let mut base_level = None;
         let field_matches = self
@@ -460,7 +457,7 @@ impl Dynamics {
                     return Some(f);
                 }
                 match base_level {
-                    Some(ref b) if &d.level > b => base_level = Some(d.level.clone()),
+                    Some(ref b) if d.level > *b => base_level = Some(d.level.clone()),
                     None => base_level = Some(d.level.clone()),
                     _ => {}
                 }

tracing-subscriber/src/fmt/mod.rs

@@ -413,7 +413,6 @@ where
 {
     /// Configures the subscriber being built to allow filter reloading at
     /// runtime.
-    #[allow(clippy::type_complexity)]
     pub fn with_filter_reloading(
         self,
     ) -> SubscriberBuilder<N, E, crate::reload::Layer<crate::EnvFilter, Formatter<N, E, W>>, W>

tracing-subscriber/src/layer.rs

@@ -506,7 +506,6 @@ where
         self.try_close(id);
     }
 
-    #[allow(clippy::option_map_unit_fn)]
     fn try_close(&self, id: span::Id) -> bool {
         #[cfg(feature = "registry")]
         let subscriber = &self.inner as &dyn Subscriber;
@@ -518,7 +517,11 @@ where
             // If we have a registry's close guard, indicate that the span is
             // closing.
             #[cfg(feature = "registry")]
-            guard.as_mut().map(|g| g.is_closing());
+            {
+                if let Some(g) = guard.as_mut() {
+                    g.is_closing()
+                };
+            }
 
             self.layer.on_close(id, self.ctx());
             true