explain naming

fix config file extension

fix config file extension

make config file readable

add non-trivial process_exporter_names default

fix link to default settings

fix typo

meet Yamllint check for indenting style

avoid interpreting process-exporter Template variables by using literal and raw

attempt to remove trailing space

remove comment trailing space

explain unusual process_exporter_names setup

Author: gajowi

README.md

@@ -25,7 +25,9 @@ All variables which can be overridden are stored in [defaults/main.yml](defaults
 | `process_exporter_version` | 0.5.0 | Process exporter package version. Also accepts latest as parameter |
 | `process_exporter_web_listen_address` | "0.0.0.0:9256" | Address on which process_exporter will listen |
 | `process_exporter_config_dir` | "/etc/process_exporter" | Path to directory with process_exporter configuration |
-| `process_exporter_names` | [] | Processes which should be monitored. Syntax is the same as in https://github.com/ncabatoff/process-exporter#using-a-config-file |
+| `process_exporter_names` | [see: defaults/main.yml](defaults/main.yml#L8) | Processes which should be monitored. Syntax is the same as in https://github.com/ncabatoff/process-exporter#using-a-config-file Default is consistent with deb/rpm packages.|
+
+`process_exporter_names` handling has been set up in an unusual way to handle recommended process-exporter 'Template variables' (such as {{.Comm}}). Follow the example in [defaults/main.yml](defaults/main.yml) if you want to define custom filtering/grouping of processes that use Template variables and make sure to keep the {% raw %} block delimiters.
 
 ## Example
 

defaults/main.yml

@@ -6,4 +6,11 @@ process_exporter_web_listen_address: "0.0.0.0:9256"
 process_exporter_config_dir: '/etc/process_exporter'
 
 # Process names
-process_exporter_names: []
+# "raw" section is needed to avoid attempted interpretation
+# of process-exporter Template varables (like {{.Comm}})
+process_exporter_names: |
+  {% raw %}
+    - name: "{{.Comm}}"
+      cmdline:
+        - '.+'
+  {% endraw %}

tasks/configure.yml

@@ -13,10 +13,10 @@
     dest: "{{ process_exporter_config_dir }}/config.yml"
     content: |
       process_names:
-      {{ process_exporter_names | to_nice_yaml }}
+      {{ process_exporter_names }}
     backup: false
     owner: root
-    mode: 0640
+    mode: 0644
   when:
     - process_exporter_names != []
 

templates/process_exporter.service.j2

@@ -11,7 +11,7 @@ User={{ process_exporter_system_user }}
 Group={{ process_exporter_system_group }}
 ExecStart=/usr/local/bin/process_exporter \
 {% if process_exporter_names != [] -%}
-	--config.path {{ process_exporter_config_dir }}/config.yaml \
+	--config.path {{ process_exporter_config_dir }}/config.yml \
 {% endif -%}
 	--web.listen-address={{ process_exporter_web_listen_address }}