Skip to content

Made AsciiStr::split generic over Pattern #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Made AsciiStr::split generic over Pattern #81

wants to merge 1 commit into from

Conversation

PatrickNorton
Copy link
Contributor

AsciiStr::split currently only accepts an AsciiChar as an argument. This PR makes it so split now accepts any Pattern, and also adds impl Pattern for AsciiChar so as to not break existing code.

@tomprogrammer tomprogrammer added the nightly Requires nightly label May 31, 2022
@tomprogrammer
Copy link
Owner

The APIs std::str::pattern::{Pattern, CharSearcher} are nightly only. Should we introduce a nightly feature for enabling these. Are there better ways of conditionally building code for nightly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
nightly Requires nightly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PatrickNorton @tomprogrammer