Fix pipewire buffer processing (#74) #2
Annotations
3 errors and 42 warnings
|
Documentation
Error: Failed to create deployment (status: 404) with build version 438838d872b08431b5fd1464b167f128f0a8bb1d. Request ID EC00:1CB254:14DCADE:2A090A6:68766128 Ensure GitHub Pages has been enabled: https://github.com/tonarino/interflow/settings/pages
|
|
Documentation
HttpError: Not Found
at /home/runner/work/_actions/actions/deploy-pages/v4/node_modules/@octokit/request/dist-node/index.js:124:1
at processTicksAndRejections (node:internal/process/task_queues:95:5)
at createPagesDeployment (/home/runner/work/_actions/actions/deploy-pages/v4/src/internal/api-client.js:125:1)
at Deployment.create (/home/runner/work/_actions/actions/deploy-pages/v4/src/internal/deployment.js:74:1)
at main (/home/runner/work/_actions/actions/deploy-pages/v4/src/index.js:30:1)
|
|
Documentation
Creating Pages deployment failed
|
|
missing documentation for an associated function:
src/audio_buffer.rs#L376
warning: missing documentation for an associated function
--> src/audio_buffer.rs:376:5
|
376 | pub fn from_noninterleaved_mut(data: &'a mut [T], channels: usize) -> Option<Self> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for an associated function:
src/audio_buffer.rs#L354
warning: missing documentation for an associated function
--> src/audio_buffer.rs:354:5
|
354 | pub fn from_noninterleaved(data: &'a [T], channels: usize) -> Option<Self> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: the lint level is defined here
--> src/lib.rs:2:9
|
2 | #![warn(missing_docs)]
| ^^^^^^^^^^^^
|
|
variables can be used directly in the `format!` string:
src/duplex.rs#L184
warning: variables can be used directly in the `format!` string
--> src/duplex.rs:184:13
|
184 | log::debug!("Output samplerate changed to {}", samplerate);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
184 - log::debug!("Output samplerate changed to {}", samplerate);
184 + log::debug!("Output samplerate changed to {samplerate}");
|
|
|
variables can be used directly in the `format!` string:
src/duplex.rs#L113
warning: variables can be used directly in the `format!` string
--> src/duplex.rs:113:21
|
113 | log::error!("Input proxy: cannot send resampling channel: {}", err);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
113 - log::error!("Input proxy: cannot send resampling channel: {}", err);
113 + log::error!("Input proxy: cannot send resampling channel: {err}");
|
|
|
doc list item overindented:
src/channel_map.rs#L74
warning: doc list item overindented
--> src/channel_map.rs:74:9
|
74 | /// set in the bitset.
| ^^^ help: try using ` ` (2 spaces)
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items
= note: `#[warn(clippy::doc_overindented_list_items)]` on by default
|
|
variables can be used directly in the `format!` string:
src/backends/coreaudio.rs#L138
warning: variables can be used directly in the `format!` string
--> src/backends/coreaudio.rs:138:30
|
138 | name: Cow::Owned(format!("Channel {}", ch)),
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `#[warn(clippy::uninlined_format_args)]` on by default
help: change this to
|
138 - name: Cow::Owned(format!("Channel {}", ch)),
138 + name: Cow::Owned(format!("Channel {ch}")),
|
|
|
field `resample_config` is never read:
src/duplex.rs#L166
warning: field `resample_config` is never read
--> src/duplex.rs:166:5
|
158 | pub struct DuplexCallback<Callback> {
| -------------- field in this struct
...
166 | resample_config: ResamplingChannelConfig,
| ^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
unused import: `std::fmt::Formatter`:
src/lib.rs#L7
warning: unused import: `std::fmt::Formatter`
--> src/lib.rs:7:5
|
7 | use std::fmt::Formatter;
| ^^^^^^^^^^^^^^^^^^^
|
|
unused import: `std::fmt`:
src/lib.rs#L6
warning: unused import: `std::fmt`
--> src/lib.rs:6:5
|
6 | use std::fmt;
| ^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
missing documentation for a struct:
src/backends/pipewire/stream.rs#L127
warning: missing documentation for a struct
--> src/backends/pipewire/stream.rs:127:1
|
127 | pub struct StreamHandle<Callback> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a variant:
src/backends/pipewire/error.rs#L8
warning: missing documentation for a variant
--> src/backends/pipewire/error.rs:8:5
|
8 | GenError(#[from] libspa::pod::serialize::GenError),
| ^^^^^^^^
|
|
missing documentation for a variant:
src/backends/pipewire/error.rs#L6
warning: missing documentation for a variant
--> src/backends/pipewire/error.rs:6:5
|
6 | BackendError(#[from] pipewire::Error),
| ^^^^^^^^^^^^
|
|
missing documentation for an enum:
src/backends/pipewire/error.rs#L4
warning: missing documentation for an enum
--> src/backends/pipewire/error.rs:4:1
|
4 | pub enum PipewireError {
| ^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct:
src/backends/pipewire/driver.rs#L9
warning: missing documentation for a struct
--> src/backends/pipewire/driver.rs:9:1
|
9 | pub struct PipewireDriver {
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a method:
src/backends/pipewire/device.rs#L24
warning: missing documentation for a method
--> src/backends/pipewire/device.rs:24:5
|
24 | pub fn properties(&self) -> Result<Option<Properties>, PipewireError> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct field:
src/backends/pipewire/device.rs#L20
warning: missing documentation for a struct field
--> src/backends/pipewire/device.rs:20:5
|
20 | pub stream_properties: HashMap<Vec<u8>, Vec<u8>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct field:
src/backends/pipewire/device.rs#L19
warning: missing documentation for a struct field
--> src/backends/pipewire/device.rs:19:5
|
19 | pub stream_name: Cow<'static, str>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct field:
src/backends/pipewire/device.rs#L18
warning: missing documentation for a struct field
--> src/backends/pipewire/device.rs:18:5
|
18 | pub object_serial: Option<String>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct field:
src/backends/pipewire/device.rs#L17
warning: missing documentation for a struct field
--> src/backends/pipewire/device.rs:17:5
|
17 | pub device_type: DeviceType,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct:
src/backends/pipewire/device.rs#L15
warning: missing documentation for a struct
--> src/backends/pipewire/device.rs:15:1
|
15 | pub struct PipewireDevice {
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a module:
src/backends/pipewire/mod.rs#L4
warning: missing documentation for a module
--> src/backends/pipewire/mod.rs:4:1
|
4 | pub mod stream;
| ^^^^^^^^^^^^^^
|
|
missing documentation for a module:
src/backends/pipewire/mod.rs#L3
warning: missing documentation for a module
--> src/backends/pipewire/mod.rs:3:1
|
3 | pub mod error;
| ^^^^^^^^^^^^^
|
|
missing documentation for a module:
src/backends/pipewire/mod.rs#L2
warning: missing documentation for a module
--> src/backends/pipewire/mod.rs:2:1
|
2 | pub mod driver;
| ^^^^^^^^^^^^^^
|
|
missing documentation for a module:
src/backends/pipewire/mod.rs#L1
warning: missing documentation for a module
--> src/backends/pipewire/mod.rs:1:1
|
1 | pub mod device;
| ^^^^^^^^^^^^^^
|
|
missing documentation for a module:
src/backends/mod.rs#L23
warning: missing documentation for a module
--> src/backends/mod.rs:23:1
|
23 | pub mod pipewire;
| ^^^^^^^^^^^^^^^^
|
|
missing documentation for an associated function:
src/audio_buffer.rs#L376
warning: missing documentation for an associated function
--> src/audio_buffer.rs:376:5
|
376 | pub fn from_noninterleaved_mut(data: &'a mut [T], channels: usize) -> Option<Self> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for an associated function:
src/audio_buffer.rs#L354
warning: missing documentation for an associated function
--> src/audio_buffer.rs:354:5
|
354 | pub fn from_noninterleaved(data: &'a [T], channels: usize) -> Option<Self> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: the lint level is defined here
--> src/lib.rs:2:9
|
2 | #![warn(missing_docs)]
| ^^^^^^^^^^^^
|
|
variables can be used directly in the `format!` string:
src/duplex.rs#L184
warning: variables can be used directly in the `format!` string
--> src/duplex.rs:184:13
|
184 | log::debug!("Output samplerate changed to {}", samplerate);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
184 - log::debug!("Output samplerate changed to {}", samplerate);
184 + log::debug!("Output samplerate changed to {samplerate}");
|
|
|
variables can be used directly in the `format!` string:
src/duplex.rs#L113
warning: variables can be used directly in the `format!` string
--> src/duplex.rs:113:21
|
113 | log::error!("Input proxy: cannot send resampling channel: {}", err);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
113 - log::error!("Input proxy: cannot send resampling channel: {}", err);
113 + log::error!("Input proxy: cannot send resampling channel: {err}");
|
|
|
doc list item overindented:
src/channel_map.rs#L74
warning: doc list item overindented
--> src/channel_map.rs:74:9
|
74 | /// set in the bitset.
| ^^^ help: try using ` ` (2 spaces)
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items
= note: `#[warn(clippy::doc_overindented_list_items)]` on by default
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
src/backends/pipewire/stream.rs#L272
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> src/backends/pipewire/stream.rs:272:66
|
272 | let samples = data.chunk().size() as usize / size_of::<f32>() as usize;
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `size_of::<f32>()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
|
variables can be used directly in the `format!` string:
src/backends/pipewire/device.rs#L49
warning: variables can be used directly in the `format!` string
--> src/backends/pipewire/device.rs:49:17
|
49 | log::error!("Failed to get device name: {}", e);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `#[warn(clippy::uninlined_format_args)]` on by default
help: change this to
|
49 - log::error!("Failed to get device name: {}", e);
49 + log::error!("Failed to get device name: {e}");
|
|
|
field `resample_config` is never read:
src/duplex.rs#L166
warning: field `resample_config` is never read
--> src/duplex.rs:166:5
|
158 | pub struct DuplexCallback<Callback> {
| -------------- field in this struct
...
166 | resample_config: ResamplingChannelConfig,
| ^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
unused import: `libspa::utils::Direction`:
src/backends/pipewire/stream.rs#L12
warning: unused import: `libspa::utils::Direction`
--> src/backends/pipewire/stream.rs:12:5
|
12 | use libspa::utils::Direction;
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `std::fmt::Formatter`:
src/lib.rs#L7
warning: unused import: `std::fmt::Formatter`
--> src/lib.rs:7:5
|
7 | use std::fmt::Formatter;
| ^^^^^^^^^^^^^^^^^^^
|
|
unused import: `std::fmt`:
src/lib.rs#L6
warning: unused import: `std::fmt`
--> src/lib.rs:6:5
|
6 | use std::fmt;
| ^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
Invalid file permissions automatically fixed
mode of 'target/doc/.lock' changed from 0600 (rw-------) to 0644 (rw-r--r--)
|
|
Documentation
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Documentation
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Documentation
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Documentation
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Documentation
Environment URL '/valib' is not a valid http(s) URL, so it will not be shown as a link in the workflow graph.
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
github-pages
Expired
|
1.72 MB |
sha256:ea2db215dc6c6de48d670e228ebbacea1d107cdd69ef6ff5af82ccad08ad5196
|
|