fix: improve Project Defaults

fix lint (don't use async)
rename button
rename page path

Author: maxceem

src/helpers/projectHelper.js

@@ -285,7 +285,7 @@ export function getProjectNavLinks(project, projectId, renderFAQs) {
   const searchParams = new URLSearchParams(window.location.search)
 
   if (searchParams.get('beta') === 'true' && hasPermission(PERMISSIONS.VIEW_PROJECT_DEFAULTS)) {
-    navLinks.push({ label: 'Project Defaults', to: `/projects/${projectId}/projectDefaults`, Icon: AccountSecurityIcon, iconClassName: 'stroke' })
+    navLinks.push({ label: 'Project Defaults', to: `/projects/${projectId}/settings`, Icon: AccountSecurityIcon, iconClassName: 'stroke' })
   }
 
   return navLinks

src/projects/detail/components/EditProjectDefaultsForm/EditProjectDefaultsForm.jsx

@@ -44,26 +44,31 @@ class EditProjectDefaultsForm extends React.Component {
     }
   }
 
-  async handleSubmit() {
+  handleSubmit() {
     const {updateProject} = this.props
     const {id, terms} = this.props.project
     const newHasNda = !this.state.hasNda
     if (newHasNda) {
-      await updateProject(id, {
+      updateProject(id, {
         terms: [...new Set([...terms, DEFAULT_NDA_UUID])]
-      }, true)
+      }, true).then(() => {
+        this.setState({
+          hasNda: this.props.project.terms.indexOf(DEFAULT_NDA_UUID) >= 0
+        })
+      })
     } else {
       const newTerms = [...terms]
       if (newTerms.indexOf(DEFAULT_NDA_UUID) >= 0) {
         newTerms.splice(newTerms.indexOf(DEFAULT_NDA_UUID), 1)
-        await updateProject(id, {
+        updateProject(id, {
           terms: newTerms
-        }, true)
+        }, true).then(() => {
+          this.setState({
+            hasNda: this.props.project.terms.indexOf(DEFAULT_NDA_UUID) >= 0
+          })
+        })
       }
     }
-    this.setState({
-      hasNda: this.props.project.terms.indexOf(DEFAULT_NDA_UUID) >= 0
-    })
   }
 
   render() {
@@ -109,7 +114,7 @@ class EditProjectDefaultsForm extends React.Component {
               type="submit"
               disabled={!this.state.enableButton}
             >
-              Submit
+              Save
             </button>
           </div>
         </Formsy.Form>

src/projects/routes.jsx

@@ -59,7 +59,7 @@ const ProjectDetailWithAuth = requiresAuthentication(() =>
     <Route path="/projects/:projectId/assets" render={() => <ProjectDetail component={AssetsLibrary} />} />
     <Route path="/projects/:projectId/discussions/:discussionId?" render={() => <ProjectDetail component={ProjectMessages} />} />
     <Route path="/projects/:projectId/faqs" render={() => <ProjectDetail component={ProjectFAQContainer} />} />
-    <Route path="/projects/:projectId/projectDefaults" render={() => <ProjectDetail component={ProjectDefaultsContainer} />} />
+    <Route path="/projects/:projectId/settings" render={() => <ProjectDetail component={ProjectDefaultsContainer} />} />
     <Route render={() => <CoderBot code={404}/>} />
   </Switch>)
 )