Merge pull request #1704 from appirio-tech/dev

Promoting to Production

Author: vikasrohit

.build-info

@@ -0,0 +1 @@
+{"rndkey":"\\þû\u001c±7åI–\u0007ïˆRªÞǤ¦\u0015Š¦\u0007¥ç\u001e:ÄX)™P§","timestamp":"2018-02-17T13:13:13.277Z"}

.circleci/config.yml

@@ -0,0 +1,59 @@
+version: 2
+jobs:
+  test:
+    docker:
+      - image: circleci/node:8.9.4
+    steps:
+      - checkout
+      - restore_cache:
+          key: test-node-modules-{{ checksum "package-lock.json" }}
+      - run: npm install
+      - save_cache:
+          key: test-node-modules-{{ checksum "package-lock.json" }}
+          paths:
+            - node_modules
+      - run: npm run lint
+      - run: npm run test
+      - run: npm run build
+      - persist_to_workspace:
+          root: .
+          paths:
+            - dist
+
+  # Just tests commited code.
+  deployDev:
+    docker:
+      - image: cibuilds/aws
+    steps:
+      - checkout
+      - attach_workspace:
+          at: ./workspace
+      - run: ./deploy.sh DEV no-cache
+
+  deployProd:
+    docker:
+      - image: cibuilds/aws
+    steps:
+      - checkout
+      - attach_workspace:
+          at: ./workspace
+      - run: ./deploy.sh PROD
+
+workflows:
+  version: 2
+  build:
+    jobs:
+      - test
+      - deployDev:
+          requires:
+            - test
+          filters:
+            branches:
+              only: dev
+      - deployProd:
+          requires:
+            - test
+          filters:
+            branches:
+              only: master
+            

.eslintrc.json

@@ -28,7 +28,7 @@
     "react/jsx-closing-bracket-location": 2,
     "jsx-quotes": [2, "prefer-double"],
     "react/jsx-boolean-value": 2,
-    "react/wrap-multilines": 2,
+    "react/jsx-wrap-multilines": 2,
     "react/self-closing-comp": 2,
     "react/no-is-mounted": 2
   },

README.md

@@ -1,4 +1,4 @@
-#### For folks working on this code base, we're ogaznizing coding style and general guidelines [here](https://github.com/appirio-tech/connect-app/wiki/Community-Work-Read-Me-First!).
+#### For folks working on this code base, we're organizing coding style and general guidelines [here](https://github.com/appirio-tech/connect-app/wiki/Community-Work-Read-Me-First!).
 
 # TC Deployment Notes
 _[TC Deployment Notes should always be kept up to date **on the default branch**. Update these notes when changes to this information occur]_

circle.yml

@@ -0,0 +1,12 @@
+/**
+ * Babel config for CoffeeScript only.
+ *
+ * We disable modules for `env` preset of `babel` for CoffeeScript to avoid error
+ * 'Uncaught ReferenceError exports is not defined'
+ */
+const topCoderBabelConfig = require('topcoder-react-utils/config/babel/webpack')
+
+const envPresetIndex = topCoderBabelConfig.presets.find((preset) => preset === 'env')
+topCoderBabelConfig.presets.splice(envPresetIndex, 1, ['env', { modules: false }])
+
+module.exports = topCoderBabelConfig

config/babel/webpack-coffee.js

@@ -0,0 +1,44 @@
+/**
+ * Function which is applied to webpack config from topcoder-react-utils
+ * and perform some common modification specific to connect app which cannot be applied using
+ * webpack merge.
+ */
+
+module.exports = function (config) {
+  /*
+    Exclude some folders from babel-loader
+   */
+  const jsxRule = config.module.rules.find(rule => /jsx/.test(rule.test.toString()))
+  jsxRule.exclude = [
+    /node_modules[\\/](?!appirio-tech.*|topcoder|tc-)/,
+    /src[\\/]assets[\\/]fonts/
+  ]
+
+  /*
+    Add babel-plugin-lodash to exclude full lodash lib and include only necessary methods
+   */
+  jsxRule.options.plugins = (jsxRule.options.plugins || []).concat(['lodash'])
+
+  /*
+    Include packages `appirio-tech-react-components` and `tc-ui`
+    to `.scss` rule
+   */
+  const scssRule = config.module.rules.find(rule => /scss/.test(rule.test.toString()))
+  scssRule.exclude = /node_modules[\\/](?!appirio-tech-react-components|tc-ui)/
+
+  /*
+    Remove outputPath as otherwise in development mode files cannot be found
+    in the webpack in-memory filesystem
+    TODO understand why it happens, fix it another way, remove this
+   */
+  const imagesRule = config.module.rules.find(rule => /gif/.test(rule.test.toString()))
+  delete imagesRule.options.outputPath
+
+  /*
+    Remove outputPath as otherwise in development mode files cannot be found
+    in the webpack in-memory filesystem
+    TODO understand why it happens, fix it another way, remove this
+   */
+  const fontsRule = config.module.rules.find(rule => /woff2/.test(rule.test.toString()))
+  delete fontsRule.options.outputPath
+}

config/webpack/common-modifications.js

@@ -0,0 +1,100 @@
+/**
+ * Common part of webpack config specific to connect app
+ *
+ * This config is merged to development and production configs
+ * and is not supposed to be used directly by itself.
+ */
+'use strict'
+
+const _ = require('lodash')
+const path = require('path')
+const webpack = require('webpack')
+const HtmlWebpackPlugin = require('html-webpack-plugin')
+const constants = require('../constants')
+
+const dirname = path.resolve(__dirname, '../..')
+
+module.exports = {
+  /*
+    Connect app has different output folder rather than topcoder-react-utils
+    So update it
+   */
+  output: {
+    path: path.join(dirname, '/dist'),
+    filename: '[name].[hash].js',
+    chunkFilename: '[name].[hash].js',
+    publicPath: '/'
+  },
+
+  resolve: {
+    /*
+      Connect app depends on `appirio-tech-react-components` which uses
+      CoffeeScript so we have to add support for these formats
+     */
+    extensions: [
+      '.coffee',
+      '.litcoffee',
+      '.cjsx'
+    ],
+    alias: {
+    /*
+      Connect app uses handlebars which has some issue with webpack
+      We have to create an alias to concrete file in order to import it
+     */
+      handlebars: 'handlebars/dist/handlebars.min.js'
+    }
+  },
+
+  module: {
+    rules: [{
+      /*
+        Connect app depends on `appirio-tech-react-components` which uses
+        CoffeeScript so we have to add support for it
+
+        Note, that we use custom babel config for coffee script which disables modules
+       */
+      test: /\.(coffee|litcoffee|cjsx)$/,
+      use: [
+        {
+          loader: 'babel-loader',
+          options: {
+            babelrc: false,
+            forceEnv: 'development', // by default set env to 'development'
+            presets: [path.resolve(dirname, './config/babel/webpack-coffee.js')],
+            plugins: ['lodash']
+          }
+        },
+        'coffee-loader',
+        'cjsx-loader'
+      ]
+    }, {
+      /*
+        Load SVG files not handled by inline-react-svg babel plugin
+      */
+      test: /\.svg$/,
+      loader: 'file-loader'
+    }],
+  },
+
+  plugins: [
+    /*
+      Connect app has a custom html template file, so we use it
+     */
+    new HtmlWebpackPlugin({
+      template: path.join(dirname, '/src/index.html'),
+      inject: 'body'
+    }),
+
+    /*
+      Connect app requires a lot of env vars which are defined in constants.
+     */
+    new webpack.DefinePlugin({
+      'process.env': _.mapValues(constants, (value) => JSON.stringify(value))
+    }),
+
+    /*
+      Remove some unused files to reduce bundle size
+     */
+    new webpack.IgnorePlugin(/^\.\/locale$/, /moment$/)
+  ]
+}