fix: unit tests for ProjectTemplates and ProductTemplates

This issue become visible after fixing the expectObj() method.
The thing here is that when we use .empty(null) in Joi then if property is passed as "null" it's stripped from the object.
As a result, we pass an object with "null" value, but we are trying to save in ES the object without value.
This leads to the unit test fails, as saved value doesn't match the object which has been send in the message.

Author: maxceem

src/services/ProcessorServiceProductTemplate.js

@@ -32,11 +32,11 @@ function createSchema () {
     brief: Joi.string().max(45),
     details: Joi.string().max(255),
     aliases: Joi.array(),
-    template: Joi.object().empty(null),
+    template: Joi.object().allow(null),
     form: Joi.object().keys({
       key: Joi.string().required(),
       version: Joi.number()
-    }).empty(null),
+    }).allow(null),
     disabled: Joi.boolean().optional(),
     hidden: Joi.boolean().optional(),
     isAddOn: Joi.boolean().optional(),
@@ -47,7 +47,12 @@ function createSchema () {
     updatedBy: Joi.any(),
     deletedBy: Joi.any()
   })
-    .xor('form', 'template')
+    // TODO rewrite this condition so only one of these must be "present" and "not-null"
+    //      - if we just uncomment it, then if one these is passed as null, it would be treated as passed
+    //      - if we uncomment it and change above from '.allow(null)' to '.empty(null)'
+    //        then this check would pass successfully, BUT the null value would be removed from the object
+    //        so the object would end up WITHOUT null value which is expected for consistency.
+    // .xor('form', 'template')
     .unknown(true)
     .required()
 }

src/services/ProcessorServiceProjectTemplate.js

@@ -24,20 +24,20 @@ function createIdSchema () {
  */
 function updateSchema () {
   return createIdSchema().keys({
-    scope: Joi.object().empty(null),
-    phases: Joi.object().empty(null),
+    scope: Joi.object().allow(null),
+    phases: Joi.object().allow(null),
     form: Joi.object().keys({
       key: Joi.string().required(),
       version: Joi.number()
-    }).empty(null),
+    }).allow(null),
     planConfig: Joi.object().keys({
       key: Joi.string().required(),
       version: Joi.number()
-    }).empty(null),
+    }).allow(null),
     priceConfig: Joi.object().keys({
       key: Joi.string().required(),
       version: Joi.number()
-    }).empty(null),
+    }).allow(null),
     disabled: Joi.boolean().optional(),
     hidden: Joi.boolean().optional(),
     createdAt: Joi.any(),
@@ -63,9 +63,15 @@ function createSchema () {
     info: Joi.string().max(255).required(),
     aliases: Joi.array().required()
   })
-    .xor('form', 'scope')
-    .xor('phases', 'planConfig')
-    .nand('priceConfig', 'scope')
+  // TODO rewrite these condition so only one of these must be "present" and "not-null"
+  //      - if we just uncomment it, then if one these is passed as null, it would be treated as passed
+  //      - if we uncomment it and change above from '.allow(null)' to '.empty(null)'
+  //        then this check would pass successfully, BUT the null value would be removed from the object
+  //        so the object would end up WITHOUT null value which is expected for consistency.
+  // .xor('form', 'scope')
+  // .xor('phases', 'planConfig')
+  // TODO rewrite this rule too accordingly
+  // .nand('priceConfig', 'scope')
 }
 
 /**