Merge pull request #837 from topcoder-platform/PM-1499_allow-pm-to-edit

PM-1499 - update opportunity type

Author: vas3a

src/routes/copilotRequest/update.js

@@ -63,6 +63,12 @@ module.exports = [
         throw err;
       }
 
+      if (['canceled', 'fulfilled'].includes(copilotRequest.status)) {
+        const err = new Error(`Copilot request with status ${copilotRequest.status} cannot be updated!`);
+        err.status = 400;
+        throw err;
+      }
+
       // check if same type of copilot request already exists
       if (patchData.projectType !== undefined && patchData.projectType !== copilotRequest.data.projectType) {
         const sameTypeRequest = await models.CopilotRequest.findOne({
@@ -87,6 +93,11 @@ module.exports = [
         }
       }
 
+      // if type changes, make sure we update "type" on opportunity as well
+      if (patchData.projectType) {
+        patchData.type = patchData.projectType;
+      }
+
       // Only update fields provided in patchData
       await copilotRequest.update(_.assign({
         data: _.assign(copilotRequest.data, patchData),