fix: review comments

Author: hentrymartin

src/constants.js

@@ -307,6 +307,10 @@ export const CONNECT_NOTIFICATION_EVENT = {
   EXTERNAL_ACTION_EMAIL: 'external.action.email',
 };
 
+export const TEMPLATE_IDS = {
+  APPLY_COPILOT: 'd-d7c1f48628654798a05c8e09e52db14f',
+  CREATE_REQUEST: 'd-3efdc91da580479d810c7acd50a4c17f'
+}
 export const REGEX = {
   URL: /^(http(s?):\/\/)?(www\.)?[a-zA-Z0-9\.\-\_]+(\.[a-zA-Z]{2,15})+(\:[0-9]{2,5})?(\/[a-zA-Z0-9\_\-\s\.\/\?\%\#\&\=;]*)?$/, // eslint-disable-line
 };

src/routes/copilotOpportunityApply/create.js

@@ -6,7 +6,7 @@ import config from 'config';
 import models from '../../models';
 import util from '../../util';
 import { PERMISSION } from '../../permissions/constants';
-import { CONNECT_NOTIFICATION_EVENT, COPILOT_OPPORTUNITY_STATUS } from '../../constants';
+import { CONNECT_NOTIFICATION_EVENT, COPILOT_OPPORTUNITY_STATUS, TEMPLATE_IDS, USER_ROLE } from '../../constants';
 import { createEvent } from '../../services/busApi';
 
 const applyCopilotRequestValidations = {
@@ -68,13 +68,13 @@ module.exports = [
 
       return models.CopilotApplication.create(data)
         .then(async (result) => {
-          const pmRole = await util.getRolesByRoleName('Project Manager', req.log, req.id);
+          const pmRole = await util.getRolesByRoleName(USER_ROLE.PROJECT_MANAGER, req.log, req.id);
           const { subjects = [] } = await util.getRoleInfo(pmRole[0], req.log, req.id);
 
           const creator = await util.getMemberDetailsByUserIds([opportunity.userId], req.log, req.id);
           const listOfSubjects = subjects;
           if (creator) {
-            const isCreatorPartofSubjects = subjects.find(item => item.email === creator[0].email);
+            const isCreatorPartofSubjects = subjects.find(item => item.email.toLowerCase() === creator[0].email.toLowerCase());
             if (!isCreatorPartofSubjects) {
               listOfSubjects.push({
                 email: creator[0].email,
@@ -91,7 +91,7 @@ module.exports = [
                   user_name: subject.handle,
                   opportunity_details_url: `${copilotPortalUrl}/opportunity/${opportunity.id}#applications`,
                 },
-                sendgrid_template_id: "d-d7c1f48628654798a05c8e09e52db14f",
+                sendgrid_template_id: TEMPLATE_IDS.APPLY_COPILOT,
                 recipients: [subject.email],
                 version: 'v3',
               }, req.log);

src/routes/copilotRequest/approveRequest.service.js

@@ -2,7 +2,7 @@ import _ from 'lodash';
 import config from 'config';
 
 import models from '../../models';
-import { CONNECT_NOTIFICATION_EVENT, COPILOT_REQUEST_STATUS } from '../../constants';
+import { CONNECT_NOTIFICATION_EVENT, COPILOT_REQUEST_STATUS, TEMPLATE_IDS, USER_ROLE } from '../../constants';
 import util from '../../util';
 import { createEvent } from '../../services/busApi';
 
@@ -56,19 +56,18 @@ module.exports = (req, data, existingTransaction) => {
                   .create(data, { transaction });
               }))
               .then(async (opportunity) => {
-                const roles = await util.getRolesByRoleName('copilot', req.log, req.id);
+                const roles = await util.getRolesByRoleName(USER_ROLE.TC_COPILOT, req.log, req.id);
                 const { subjects = [] } = await util.getRoleInfo(roles[0], req.log, req.id);
                 const emailEventType = CONNECT_NOTIFICATION_EVENT.EXTERNAL_ACTION_EMAIL;
                 const copilotPortalUrl = config.get('copilotPortalUrl');
                 req.log.info("Sending emails to all copilots about new opportunity");
                 subjects.forEach(subject => {
-                  req.log.info("Each copilot members", subject);
                   createEvent(emailEventType, {
                     data: {
                       user_name: subject.handle,
                       opportunity_details_url: `${copilotPortalUrl}/opportunity/${opportunity.id}`,
                     },
-                    sendgrid_template_id: "d-3efdc91da580479d810c7acd50a4c17f",
+                    sendgrid_template_id: TEMPLATE_IDS.CREATE_REQUEST,
                     recipients: [subject.email],
                     version: 'v3',
                   }, req.log);